From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-nfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: unlock i_mutex in xfs_break_layouts
Date: Wed, 8 Apr 2015 18:24:03 +0200 [thread overview]
Message-ID: <20150408162403.GD16052@lst.de> (raw)
In-Reply-To: <20150407221927.GD15810@dastard>
On Wed, Apr 08, 2015 at 08:19:27AM +1000, Dave Chinner wrote:
> That's kinda nasty, and it has no documentation explaining when or
> why we'd need to drop the i_mutex. How are we supposed to know if we
> need to drop the i_mutex or not?
We need to drop it if we hold it, pretty easy.
> What happens if the upper VFS
> layers change or we have a multiple call paths that have different
> i_mutex contexts (i.e. one holds, another doesn't)?
We avoid this in the VFS, as everytime we had it filesystems were getting it
wrong.
However you have a point in that we should probably have asserts that the
right locks are held.
> Which makes me wonder - is this layout breaking stuff at the right
> layer?
We can't do it in the VFS as it needs to be atomic vs the lock that
protects write in ->write and ->fallocate, which is only taken in
the filesystem. For ->setattr in theory we could do it in the VFS,
but if the other callers can't do it in the VFS that will just lead
to code duplication.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-04-08 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 15:35 [PATCH] xfs: unlock i_mutex in xfs_break_layouts Christoph Hellwig
2015-04-07 21:07 ` J. Bruce Fields
2015-04-08 16:21 ` Christoph Hellwig
2015-04-08 18:16 ` J. Bruce Fields
2015-04-07 22:19 ` Dave Chinner
2015-04-08 16:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408162403.GD16052@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox