* [PATCH] xfs: xfs_iozero can return positive errno
@ 2015-04-16 12:38 Dave Chinner
2015-04-16 17:32 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Dave Chinner @ 2015-04-16 12:38 UTC (permalink / raw)
To: xfs
From: Dave Chinner <dchinner@redhat.com>
It was missed when we converted everything in XFs to use negative error
numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
error sign conversion"), and should go back to stable kernels.
Thanks to Brian Foster for noticing it.
cc: <stable@vger.kernel.org> # 3.17, 3.18, 3.19, 4.0
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/xfs_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index ec0c9c2..8383df0 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -125,7 +125,7 @@ xfs_iozero(
status = 0;
} while (count);
- return (-status);
+ return status;
}
int
--
2.0.0
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: xfs_iozero can return positive errno
2015-04-16 12:38 [PATCH] xfs: xfs_iozero can return positive errno Dave Chinner
@ 2015-04-16 17:32 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2015-04-16 17:32 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
On Thu, Apr 16, 2015 at 10:38:41PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> It was missed when we converted everything in XFs to use negative error
> numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
> error sign conversion"), and should go back to stable kernels.
>
> Thanks to Brian Foster for noticing it.
>
> cc: <stable@vger.kernel.org> # 3.17, 3.18, 3.19, 4.0
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index ec0c9c2..8383df0 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -125,7 +125,7 @@ xfs_iozero(
> status = 0;
> } while (count);
>
> - return (-status);
> + return status;
> }
>
> int
> --
> 2.0.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-16 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-16 12:38 [PATCH] xfs: xfs_iozero can return positive errno Dave Chinner
2015-04-16 17:32 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox