public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Joe Landman <joe.landman@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: question: are the metadata crc elements ready for general use?
Date: Wed, 29 Apr 2015 06:53:45 +1000	[thread overview]
Message-ID: <20150428205345.GY21261@dastard> (raw)
In-Reply-To: <553FDFE0.7050800@gmail.com>

On Tue, Apr 28, 2015 at 03:30:40PM -0400, Joe Landman wrote:
> I ask as I see this in the 3.2.2 mkfs.xfs command.  The default is
> to leave them off from what I can see on an mkfs.xfs.

Yes, and we've been discussing whether they should be made the
default in the upcoming 3.2.3 release or wait for 3.3.  IIRC, the
latest SLES release already defaults to using CRCs by default.

> root@unison:~/xfsprogs# mkfs.xfs /dev/sda
> meta-data=/dev/sda               isize=256    agcount=55,
> agsize=268435455 blks
>          =                       sectsz=512   attr=2, projid32bit=1
>          =                       crc=0        finobt=0
> data     =                       bsize=4096   blocks=14627632640, imaxpct=1
>          =                       sunit=0      swidth=0 blks
> naming   =version 2              bsize=4096   ascii-ci=0 ftype=0
> log      =internal log           bsize=4096   blocks=521728, version=2
>          =                       sectsz=512   sunit=0 blks, lazy-count=1
> realtime =none                   extsz=4096   blocks=0, rtextents=0
> 
> But they are there, and I am curious as to the developers/users
> thoughts.  Will they break things (nfs, CIFS/samba)?

I enable them on all my systems, and almost all of my testing is
done with "-m crc=1,finobt=1" options set. The don't affect
applications at all - CRCs are completely transparent to userspace
so applications don't even know the filesystem is using them.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2015-04-28 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 19:30 question: are the metadata crc elements ready for general use? Joe Landman
2015-04-28 20:53 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150428205345.GY21261@dastard \
    --to=david@fromorbit.com \
    --cc=joe.landman@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox