Re: [PATCH 2/2] xfs: inode counter needs to use __percpu_counter_compare

Christoph Hellwig
2015-05-06T04:38:09Z

> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index 02f827f..900f8ce 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -1106,8 +1106,9 @@ xfs_mod_icount(
> int64_t delta)
> {
> /* deltas are +/-64, hence the large batch size of 128. */
> - __percpu_counter_add(&mp->m_icount, delta, 128);
> - if (percpu_counter_compare(&mp->m_icount, 0) < 0) {
> +#define _ICOUNT_BATCH 128
> + __percpu_counter_add(&mp->m_icount, delta, _ICOUNT_BATCH);

Can you give XFS_ prefixes to the atch sizes and move them otuside the
function? And fix up the instance in xfs_mod_fdblocks as well while
you're at it.

Otherwise looks fine.