From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfs: extent size hints can round up extents past MAXEXTLEN
Date: Wed, 27 May 2015 11:56:05 +1000 [thread overview]
Message-ID: <20150527015605.GZ15721@dastard> (raw)
In-Reply-To: <1432686984-15195-1-git-send-email-david@fromorbit.com>
On Wed, May 27, 2015 at 10:36:24AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> This results in BMBT corruption, as seen by this test:
....
> - if ((temp = (align_alen % extsz))) {
> - align_alen += extsz - temp;
> - }
> + while (align_alen > MAXEXTLEN)
> + align_alen -= extsz;
> + ASSERT(align_alen <= MAXEXTLEN);
FYI, this bit is the only difference in this version - it fixes the
test case that Brian pointed out that still didn't work properly.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-05-27 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 0:36 [PATCH v3] xfs: extent size hints can round up extents past MAXEXTLEN Dave Chinner
2015-05-27 1:56 ` Dave Chinner [this message]
2015-05-27 12:11 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527015605.GZ15721@dastard \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox