From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
Brian Foster <bfoster@redhat.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH 4/4 V2] xfsprogs: zero out clean log in xfs_metadump
Date: Wed, 10 Jun 2015 09:35:43 +1000 [thread overview]
Message-ID: <20150609233543.GS9143@dastard> (raw)
In-Reply-To: <5575DFB1.4010004@sandeen.net>
On Mon, Jun 08, 2015 at 01:32:17PM -0500, Eric Sandeen wrote:
> On 6/8/15 1:29 PM, Brian Foster wrote:
> > On Mon, Jun 08, 2015 at 10:06:34AM -0500, Eric Sandeen wrote:
> >> When doing an obfuscated xfs_metadump, if the log is clean, zero
> >> it out for 2 reasons:
> >>
> >> * It'll make the image more compressible
> >> * It'll eliminate an un-obfuscated metadata source
> >>
> >> If the log isn't clean, and the user expected obfuscation, warn
> >> that metadata in the log will not be obfuscated.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >> ---
> >>
> >> V2: If not obfuscating, copy log as-is
> >>
> >
> > FYI, I think v1 of this was already pulled into the for-next branch.
> > Anyways...
>
> Yeah, I noticed - I'll ask dave to fix it (that one rebases, right?) :)
Just send a delta patch against what I committed, that way I don't
need to rebase the tree.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-06-09 23:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 19:02 [PATCH 0/4] xfsprogs: mini patch-bomb Eric Sandeen
2015-05-29 19:03 ` [PATCH 1/4] xfsprogs: remove unused write-only var l_logsize Eric Sandeen
2015-06-03 17:11 ` Brian Foster
2015-05-29 19:06 ` [PATCH 2/4] xfsprogs: add xlog_is_empty() helper Eric Sandeen
2015-06-03 17:11 ` Brian Foster
2015-05-29 19:13 ` [PATCH 3/4] xfsprogs: rename dont_obfuscate in xfs_metadump Eric Sandeen
2015-06-03 17:11 ` Brian Foster
2015-05-29 19:17 ` [PATCH 4/4] xfsprogs: zero out clean log " Eric Sandeen
2015-06-03 17:11 ` Brian Foster
2015-06-03 20:01 ` Eric Sandeen
2015-06-08 15:06 ` [PATCH 4/4 V2] " Eric Sandeen
2015-06-08 18:29 ` Brian Foster
2015-06-08 18:32 ` Eric Sandeen
2015-06-09 23:35 ` Dave Chinner [this message]
2015-06-08 18:46 ` [PATCH 4/4 V3] " Eric Sandeen
2015-06-08 18:50 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609233543.GS9143@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox