Re: [PATCH 01/17] xfsprogs: use common code for multi-disk detection

Christoph Hellwig
2015-06-19T11:10:24Z

> index 70e43a0..3269ec3 100644
> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -26,9 +26,15 @@ QAHFILES = libxfs.h libxlog.h \
> xfs_inode.h \
> xfs_log_recover.h \
> xfs_metadump.h \
> + xfs_mkfs.h \
> xfs_mount.h \
> + xfs_quota_defs.h \
> + xfs_sb.h \
> + xfs_shared.h \
> xfs_trace.h \
> - xfs_trans.h
> + xfs_trans.h \
> + xfs_trans_resv.h \
> + xfs_trans_space.h

These shouldn't be added to the headers installed by make install-qa.

(which I'm going to send a patch to remove once Dave applied the
build fix, btw)

Also I'm not sure xfs_mkfs.h really is a good name for a global header.