From: Brian Foster <bfoster@redhat.com>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_quota: Better describe quota verbose output
Date: Tue, 30 Jun 2015 14:38:04 -0400 [thread overview]
Message-ID: <20150630183804.GA20427@bfoster.bfoster> (raw)
In-Reply-To: <1435154949-14223-1-git-send-email-cmaiolino@redhat.com>
On Wed, Jun 24, 2015 at 11:09:09AM -0300, Carlos Maiolino wrote:
> Due historical reasons, and to be compliant with the generic quota command,
> xfs_quota does not output any information when there is no used percentage of
> the available quota. Such behavior might make users confused, so, I believe it's
> better to have the reasons for such behavior better documented.
>
Seems reasonable...
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> man/man8/xfs_quota.8 | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/man/man8/xfs_quota.8 b/man/man8/xfs_quota.8
> index 9b555e9..ef90bfb 100644
> --- a/man/man8/xfs_quota.8
> +++ b/man/man8/xfs_quota.8
> @@ -197,7 +197,9 @@ option reports the numeric IDs rather than the name. The
> .B \-N
> option omits the header. The
> .B \-v
> -option outputs verbose information. The
> +option outputs verbose information, displaying quota values even when there is
> +no used space. Such behavior was chosen to be compliant with the 'quota' command
> +and for historical reasons. The
... though this sounds a bit unclear to me. Specifically, it sounds like
it could be saying that the behavior of -v has some historical
justification, when in fact, it is the absense of output in the
non-verbose case that we're trying to document (assuming I understand
the commit log correctly).
As an example, something like the following sounds more clear to me:
"The -v option outputs verbose information and includes quota limits
with no consumption. By default, xfs_quota does not display limits with
no consumption to maintain compatibility with the 'quota' command."
... but I suspect it could still be worded better.
Brian
> .B \-f
> option sends the output to
> .I file
> --
> 2.1.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-06-30 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 14:09 [PATCH] xfs_quota: Better describe quota verbose output Carlos Maiolino
2015-06-30 18:38 ` Brian Foster [this message]
2015-06-30 19:11 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630183804.GA20427@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox