From: Carlos Maiolino <cmaiolino@redhat.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_quota: Better describe quota verbose output
Date: Tue, 30 Jun 2015 16:11:45 -0300 [thread overview]
Message-ID: <20150630191145.GA6252@hades.maiolino.org> (raw)
In-Reply-To: <20150630183804.GA20427@bfoster.bfoster>
> > the available quota. Such behavior might make users confused, so, I believe it's
> > better to have the reasons for such behavior better documented.
> >
>
> Seems reasonable...
>
> > +option outputs verbose information, displaying quota values even when there is
> > +no used space. Such behavior was chosen to be compliant with the 'quota' command
> > +and for historical reasons. The
>
> ... though this sounds a bit unclear to me. Specifically, it sounds like
> it could be saying that the behavior of -v has some historical
> justification, when in fact, it is the absense of output in the
> non-verbose case that we're trying to document (assuming I understand
> the commit log correctly).
>
> As an example, something like the following sounds more clear to me:
>
> "The -v option outputs verbose information and includes quota limits
> with no consumption. By default, xfs_quota does not display limits with
> no consumption to maintain compatibility with the 'quota' command."
>
> ... but I suspect it could still be worded better.
>
Thank you for the comment Brian, I liked your idea, but, I'm also not the best
person to say if this is enough or not, I'll wait for some other comments here,
so I can send a V2 with our final decision.
Cheers
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-06-30 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 14:09 [PATCH] xfs_quota: Better describe quota verbose output Carlos Maiolino
2015-06-30 18:38 ` Brian Foster
2015-06-30 19:11 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630191145.GA6252@hades.maiolino.org \
--to=cmaiolino@redhat.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox