From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@redhat.com, xfs@oss.sgi.com, Jan Tulak <jtulak@redhat.com>
Subject: Re: [PATCH v2] xfsprogs: blkid is now mandatory
Date: Sat, 4 Jul 2015 09:45:18 +1000 [thread overview]
Message-ID: <20150703234518.GP7943@dastard> (raw)
In-Reply-To: <20150703151904.GA13839@infradead.org>
On Fri, Jul 03, 2015 at 08:19:04AM -0700, Christoph Hellwig wrote:
> Thanks Jan!
>
> On Thu, Jul 02, 2015 at 12:43:16PM +0200, Jan Tulak wrote:
> > Because blkid is here for a long time, I hereby propose a patch for removing support
> > for NOT having blkid. The current support through set of #ifdef is prone to errors like
> > making a patch just in one of the branches, and according to a recent talk between
> > Christoph and Eric, it is not necessary to keep it supported.
> >
> > Remove code for checking ENABLE_BLKID, and the code when ENABLE_BLKID is not defined.
> > The only use of libdisk was in the removed code, so remove libdisk too.
> > It makes blkid required for compilation.
>
> Can you wrap your commit description lines after ~ 75 characters,
> please?
ObBikeShed: I find 68 characters for commit messages is more
friendly, especially with the way git show pads the commit messages
and people cut/paste it into email...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-07-03 23:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 16:01 [PATCH] xfsprogs: blkid is now mandatory Jan Tulak
2015-07-01 22:55 ` Dave Chinner
2015-07-02 10:27 ` Jan Tulak
2015-07-02 10:43 ` [PATCH v2] " Jan Tulak
2015-07-03 15:19 ` Christoph Hellwig
2015-07-03 23:45 ` Dave Chinner [this message]
2015-07-07 15:10 ` Jan Tulak
2015-07-08 9:14 ` [PATCH v3] " Jan Tulak
2015-07-21 12:39 ` Jan Tulak
2015-07-26 16:25 ` Christoph Hellwig
2015-08-03 10:40 ` Jan Tulak
2015-08-03 17:20 ` Eric Sandeen
2015-08-04 15:30 ` Jan Tulak
2015-08-04 16:24 ` Eric Sandeen
2015-08-06 13:13 ` Jan Tulak
2015-08-11 16:40 ` Jan Tulak
2015-07-26 16:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703234518.GP7943@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jtulak@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox