From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files
Date: Thu, 30 Jul 2015 10:07:34 -0700 [thread overview]
Message-ID: <20150730170734.GA25395@infradead.org> (raw)
In-Reply-To: <1437913255-7524-2-git-send-email-tytso@mit.edu>
On Sun, Jul 26, 2015 at 08:20:50AM -0400, Theodore Ts'o wrote:
> Android's bionic libc doesn't define NBBY; this isn't a standard
> define, and since all modern/sane platforms have 8 bits per byte, use
> this as a default.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This looks fine, but it'll clash with my patch that changes
platform_defs.h so that it's not run through autoconfs m4 anymore.
Otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-07-30 17:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 12:20 [PATCH 0/6] Add cross-compilation support for android Theodore Ts'o
2015-07-26 12:20 ` [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files Theodore Ts'o
2015-07-30 17:07 ` Christoph Hellwig [this message]
2015-07-26 12:20 ` [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename() Theodore Ts'o
2015-07-30 17:11 ` Christoph Hellwig
2015-07-26 12:20 ` [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation Theodore Ts'o
2015-07-30 17:10 ` Christoph Hellwig
2016-02-01 21:25 ` xfsprogs: Add BUILD_CFLAGS " Gwendal Grignou
2016-02-02 18:08 ` Christoph Hellwig
2016-05-27 16:34 ` Gwendal Grignou
2016-05-31 12:51 ` Christoph Hellwig
2016-05-31 16:19 ` Gwendal Grignou
2015-07-26 12:20 ` [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item Theodore Ts'o
2015-07-30 17:11 ` Christoph Hellwig
2015-07-26 12:20 ` [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort Theodore Ts'o
2015-07-30 17:09 ` Christoph Hellwig
2015-07-26 12:20 ` [PATCH 6/6] xfsprogs: add missing include of <stat.h> Theodore Ts'o
2015-07-30 17:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730170734.GA25395@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox