Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files

Christoph Hellwig
2015-07-30T17:07:39Z

On Sun, Jul 26, 2015 at 08:20:50AM -0400, Theodore Ts'o wrote:
> Android's bionic libc doesn't define NBBY; this isn't a standard
> define, and since all modern/sane platforms have 8 bits per byte, use
> this as a default.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

This looks fine, but it'll clash with my patch that changes
platform_defs.h so that it's not run through autoconfs m4 anymore.

Otherwise:

Reviewed-by: Christoph Hellwig <hch@lst.de>