From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH RFC 1/2] xfs: return committed status from xfs_trans_roll()
Date: Thu, 30 Jul 2015 10:21:01 -0700 [thread overview]
Message-ID: <20150730172101.GA31255@infradead.org> (raw)
In-Reply-To: <20150728134006.GD38784@bfoster.bfoster>
On Tue, Jul 28, 2015 at 09:40:06AM -0400, Brian Foster wrote:
> > Hmmm - something I just noticed: if we only have one EFD per EFI,
> > why do we do we have that layer of extent counting before dropping
> > real references?
> >
>
> I wondered this myself, but hadn't made it deep enough to see if we used
> the reference count elsewhere.
Because the elders (no pun on Alex, sorry :)) didn't realize we
a) don't even ever look at at the logged extents in EFD
b) have a 1:1 relationship between EFIs and EFDs
I tried to sort some of that out about a year ago, but I didn't manage
to get far.
have just one. Note that not having to log these
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-07-30 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 20:13 [PATCH RFC 0/2] xfs: fix up EFI/EFD error handling Brian Foster
2015-07-23 20:13 ` [PATCH RFC 1/2] xfs: return committed status from xfs_trans_roll() Brian Foster
2015-07-28 0:40 ` Dave Chinner
2015-07-28 13:40 ` Brian Foster
2015-07-28 21:51 ` Dave Chinner
2015-07-29 11:47 ` Brian Foster
2015-07-30 17:21 ` Christoph Hellwig [this message]
2015-08-10 18:55 ` Brian Foster
2015-07-23 20:13 ` [PATCH RFC 2/2] xfs: fix efi/efd error handling to avoid fs shutdown hangs Brian Foster
2015-07-29 22:18 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730172101.GA31255@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox