From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: fix syntax error in include/buildmacros
Date: Tue, 4 Aug 2015 04:16:35 -0700 [thread overview]
Message-ID: <20150804111635.GA18906@infradead.org> (raw)
In-Reply-To: <1438659509-16656-1-git-send-email-eguan@redhat.com>
On Tue, Aug 04, 2015 at 11:38:29AM +0800, Eryu Guan wrote:
> There's an extra ";" in include/buildmacros, which causes make
> install-dev to fail
>
> ......
> Installing libhandle-install-dev
> cd ../libhandle/.libs; ... if [ "x/usr/lib64" != "x/usr/lib64"; ]; ...
> /bin/sh: line 0: [: missing `]'
> /bin/sh: ]: command not found
> ......
>
> This was introduced by
> 02ef543 libhandle: fix installation for symlinked /usr
Thanks, loosk like some shells are stricter than others here.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-08-04 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 3:38 [PATCH] xfsprogs: fix syntax error in include/buildmacros Eryu Guan
2015-08-04 11:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804111635.GA18906@infradead.org \
--to=hch@infradead.org \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox