* [PATCH] xfsprogs: fix syntax error in include/buildmacros
@ 2015-08-04 3:38 Eryu Guan
2015-08-04 11:16 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Eryu Guan @ 2015-08-04 3:38 UTC (permalink / raw)
To: xfs; +Cc: Eryu Guan
There's an extra ";" in include/buildmacros, which causes make
install-dev to fail
......
Installing libhandle-install-dev
cd ../libhandle/.libs; ... if [ "x/usr/lib64" != "x/usr/lib64"; ]; ...
/bin/sh: line 0: [: missing `]'
/bin/sh: ]: command not found
......
This was introduced by
02ef543 libhandle: fix installation for symlinked /usr
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
include/buildmacros | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/buildmacros b/include/buildmacros
index 4e4e8fa..a7c5d8a 100644
--- a/include/buildmacros
+++ b/include/buildmacros
@@ -77,7 +77,7 @@ INSTALL_LTLIB_DEV = \
../$(INSTALL) -m 755 -d $(PKG_ROOT_LIB_DIR); \
../$(INSTALL) -T so_base $(LIBNAME).lai $(PKG_ROOT_LIB_DIR); \
if [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \
- "x$(shell readlink -f $(PKG_ROOT_LIB_DIR))"; ]; then \
+ "x$(shell readlink -f $(PKG_ROOT_LIB_DIR))" ]; then \
../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).a $(PKG_ROOT_LIB_DIR)/$(LIBNAME).a; \
../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).la $(PKG_ROOT_LIB_DIR)/$(LIBNAME).la; \
../$(INSTALL) -S $(PKG_ROOT_LIB_DIR)/$(LIBNAME).so $(PKG_LIB_DIR)/$(LIBNAME).so; \
--
2.4.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfsprogs: fix syntax error in include/buildmacros
2015-08-04 3:38 [PATCH] xfsprogs: fix syntax error in include/buildmacros Eryu Guan
@ 2015-08-04 11:16 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2015-08-04 11:16 UTC (permalink / raw)
To: Eryu Guan; +Cc: xfs
On Tue, Aug 04, 2015 at 11:38:29AM +0800, Eryu Guan wrote:
> There's an extra ";" in include/buildmacros, which causes make
> install-dev to fail
>
> ......
> Installing libhandle-install-dev
> cd ../libhandle/.libs; ... if [ "x/usr/lib64" != "x/usr/lib64"; ]; ...
> /bin/sh: line 0: [: missing `]'
> /bin/sh: ]: command not found
> ......
>
> This was introduced by
> 02ef543 libhandle: fix installation for symlinked /usr
Thanks, loosk like some shells are stricter than others here.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-04 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-04 3:38 [PATCH] xfsprogs: fix syntax error in include/buildmacros Eryu Guan
2015-08-04 11:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox