public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Detlef Vollmann <dv@vollmann.ch>
Cc: xfs@oss.sgi.com
Subject: Re: xfsdump doesn't compile: undefined reference to 'min'
Date: Fri, 7 Aug 2015 07:26:20 +1000	[thread overview]
Message-ID: <20150806212620.GD3902@dastard> (raw)
In-Reply-To: <55C312CF.2040408@vollmann.ch>

On Thu, Aug 06, 2015 at 09:54:55AM +0200, Detlef Vollmann wrote:
> > commit 5a2985233c390d59d2a9757b119cb0e001c87a96
> > Author: Dave Chinner <dchinner@redhat.com>
> > Date:   Fri Jul 18 08:02:26 2014 +1000
> >
> >     dump: don't redefine min() or max()
> >
> >     They are included from other header files.
> The message doesn't say from which header and configure doesn't test
> for it.
> If I compile it (cross-compilation, gcc, uclibc, xfsprogs 3.1.11,
> xfsdump 3.1.4), I get lots of errors:
> warning: implicit declaration of function 'max'
> undefined reference to 'min'

#include <xfs/xfs.h>
  -> /usr/include/xfs/xfs.h
     #include <xfs/platform_defs.h>
       -> /usr/include/xfs/platform_defs.h
          #define min(a,b)	(((a)<(b))?(a):(b))

These headers come from xfsprogs, and you'll need to upgrade that
package to 3.2.x....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2015-08-06 21:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06  7:54 xfsdump doesn't compile: undefined reference to 'min' Detlef Vollmann
2015-08-06 21:26 ` Dave Chinner [this message]
2015-08-07 12:16   ` Detlef Vollmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150806212620.GD3902@dastard \
    --to=david@fromorbit.com \
    --cc=dv@vollmann.ch \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox