From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] db: fix uninitialised variable warnings
Date: Fri, 7 Aug 2015 07:37:06 -0400 [thread overview]
Message-ID: <20150807113705.GA8322@bfoster.bfoster> (raw)
In-Reply-To: <1438814992-31588-1-git-send-email-david@fromorbit.com>
On Thu, Aug 06, 2015 at 08:49:52AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> New versions of gcc barf on the conversion table code in
> db/convert.c. Shut it up by initialising the conversion array.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> db/convert.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/db/convert.c b/db/convert.c
> index 09f9225..a337abe 100644
> --- a/db/convert.c
> +++ b/db/convert.c
> @@ -157,7 +157,7 @@ convert_f(int argc, char **argv)
> {
> ctype_t c;
> int conmask;
> - cval_t cvals[NCTS];
> + cval_t cvals[NCTS] = {};
> int i;
> int mask;
> __uint64_t v;
> --
> 2.1.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-08-07 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 22:49 [PATCH] db: fix uninitialised variable warnings Dave Chinner
2015-08-07 11:37 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807113705.GA8322@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox