From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 4253A7F81 for ; Thu, 13 Aug 2015 20:54:12 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id CC5EAAC003 for ; Thu, 13 Aug 2015 18:54:11 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id q5ZBpE3XP4NfaSwF for ; Thu, 13 Aug 2015 18:54:08 -0700 (PDT) Date: Fri, 14 Aug 2015 11:53:09 +1000 From: Dave Chinner Subject: Re: [PATCH 1/8] xfs: Introduce writeback context for writepages Message-ID: <20150814015309.GU3902@dastard> References: <1439333388-16452-1-git-send-email-david@fromorbit.com> <1439333388-16452-2-git-send-email-david@fromorbit.com> <20150812072635.GA32399@infradead.org> <20150813013244.GP3902@dastard> <20150813065258.GA677@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150813065258.GA677@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Wed, Aug 12, 2015 at 11:52:58PM -0700, Christoph Hellwig wrote: > On Thu, Aug 13, 2015 at 11:32:44AM +1000, Dave Chinner wrote: > > > http://thread.gmane.org/gmane.comp.file-systems.xfs.general/39030/focus=39009 > > > > I completely forgot you did this. I'll go back and look at it > > and see what I can pull from it. Thanks for the reminder, Christoph. > > As far as I can tell your new version is superior in all aspects > except for the patch split :) Ok, I've gone back and had a look at this now and reminded myself of the discussion we had and the problems found. The end results are remarkably similar - maybe that's why I found it easy to write this patch set. i.e. your patchset was buried somewhere in my brain, even though I'd forgotten about it at the surface... How would you like to see this patchset broken up into more sensible/reviewable chunks? It's just folding and splitting patches, so it's not a big deal to rework it... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs