Re: [PATCH] v3 inodes are only valid on crc-enabled filesystems

[Dave Chinner <david@fromorbit.com>]

On Sun, Aug 16, 2015 at 12:34:24PM +0100, Roger Willcocks wrote:
> Fix an xfs_repair regression reported by Leslie Rhorer where a bad
> (v3) inode version number was not reset.
> 
> Signed-off-by: Roger Willcocks <roger@filmlight.ltd.uk>

Hi Roger,

Just a FYI - the patch has mangled whitespace:
in it.

> ---
> db/check.c             |  2 +-
> include/libxfs.h       |  2 +-
> include/xfs_dinode.h   | 10 +++++++++-
> libxfs/xfs_inode_buf.c |  2 +-
> repair/dinode.c        |  7 +++----
> repair/prefetch.c      |  2 +-
> 6 files changed, 16 insertions(+), 9 deletions(-)
> 
> diff --git a/db/check.c b/db/check.c
> index c4c972f..b5c3b8e 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -2637,7 +2637,7 @@ process_inode(
> 		error++;
> 		return;
> 	}
> -	if (!XFS_DINODE_GOOD_VERSION(idic.di_version)) {
> +	if (!xfs_dinode_good_version(mp, idic.di_version)) {
> 		if (isfree || v)
> 			dbprintf(_("bad version number %#x for inode %lld\n"),
> 				idic.di_version, ino);

All the patch hunks are missing the leading " " for non-modified
lines. I've fixed it manually, but can you make sure future patches
are not mangled?

> -- 
> 2.5.0.rc0

IMO, it's best not to use development versions of git for anything
other than testing.... ;)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs