Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support

Jan Tulak
2015-08-19T09:15:07Z

[-- Attachment #1.1: Type: text/plain, Size: 1513 bytes --]

On Wed, Aug 19, 2015 at 10:09 AM, Christoph Hellwig <hch@infradead.org>
wrote:
>
> On Wed, Aug 19, 2015 at 07:45:57AM +1000, Dave Chinner wrote:
> > Hmmm, looks like I accidentally comitted an earlier version of this
> > patch yesterday. Jan, can you send delta patches to what I committed
> > to address more recent review comments? Sorry, my bad.

I guess my chaotic versioning can be blamed. :-)

> Can you revert it for now? I think most of these changes are incorrect

I agree, revert seems like a better idea. Especially if we want to split
things
like removing the XATTR_ dependency move into standalone commits.

> and should either be dropped for now by disabling fsx

I proposed dropping some tools earlier, but there was a valid point about
the possibility to break something when not even trying to compile it.
i.e. with the XATTR_ -> XFS_XATTR mentioned in the first reply to this patch
(which I already moved to a separate patch), it is necessary to add

#include "xfs/xfs_arch.h"
#include "xfs/xfs_format.h"

into libhandle/handle.c. But
​
I found
​
this
​
when I tried to compile it. If it was
in fsr and fsr wasn't compiling, I would most likely send a patch which
would
be thrown
​
back
​
on my head immediately. ;-)

So I think
​ ​
it is better to have "bad dummy stuff" than not compile it
at all
​
.

> or will need
​
a major rework.

Working on it. :-)

Cheers,
Jan

--
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 2595 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]