Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support

Dave Chinner
2015-08-21T00:51:55Z

On Thu, Aug 20, 2015 at 09:33:33AM +0200, Jan Tulak wrote:
> On Thu, Aug 20, 2015 at 2:22 AM, Dave Chinner <david@fromorbit.com> wrote:
>
> > On Wed, Aug 19, 2015 at 08:26:23PM +1000, Dave Chinner wrote:
> > > On Wed, Aug 19, 2015 at 01:09:40AM -0700, Christoph Hellwig wrote:
> > > > On Wed, Aug 19, 2015 at 07:45:57AM +1000, Dave Chinner wrote:
> > > > > Hmmm, looks like I accidentally comitted an earlier version of this
> > > > > patch yesterday. Jan, can you send delta patches to what I committed
> > > > > to address more recent review comments? Sorry, my bad.
> > > >
> > > > Can you revert it for now? I think most of these changes are incorrect
> > > > and should either be dropped for now by disabling fsx or will need
> > > > a major rework.
> > >
> > > I'll just rebase the for-next branch, I guess, and remove it
> > > completely from the history. I've got another lockdep fix that needs
> > > to be pushed before it all hits tomorrow's linux-next build, anyway.
> >
> > Getting my trees mixed up. I'll revert the patch on the next push.
>
>
> ​And as I noticed, '
> xfsprogs: Add includes required for OS X builds
> ​' was ​also
> selected in an older version. Other patches looks OK, though. :-)
> Should I send delta patch for that one? It is just about three #includes.

Yes.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com