Re: [PATCH 08/11] xfsprogs: replace obsolete memalign with posix_memalign

Christoph Hellwig
2015-08-17T19:36:25Z

On Mon, Aug 17, 2015 at 06:23:23PM +0200, Jan Tulak wrote:
> Memalign from <malloc.h> was marked obsolete in favor of a posix
> variant from <stdlib.h>. So replace all calls and remove <malloc.h>
> includes. This also enhances support on other posix platforms,
> which doesn't have <malloc.h>.
>
> Because posix_memalign returns any error as a return code, not in
> errno, change relevant checks in code (and add a missing one).

I have to say I hate the posix_memalign calling convention. Any chance
you could just provide a memalign impementation using posix_memalign for
MacOS?

Something like:

static inline void *memalign(size_t alignment, size_t size)
{
int error;
void *buf;

error = posix_memalign(&buf, alignment, size);
if (error)
errno = error;
buf = NULL;
}

return buf;
}