From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: inode lockdep annotations broke non-lockdep build
Date: Fri, 21 Aug 2015 07:09:06 -0400 [thread overview]
Message-ID: <20150821110906.GA46372@bfoster.bfoster> (raw)
In-Reply-To: <20150821004254.GV714@dastard>
On Fri, Aug 21, 2015 at 10:42:54AM +1000, Dave Chinner wrote:
> On Thu, Aug 20, 2015 at 07:32:00AM -0400, Brian Foster wrote:
> > On Wed, Aug 19, 2015 at 08:23:34PM +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
...
>
> > Perhaps it's best to just use the #define in both cases?
>
> -#ifdef CONFIG_LOCKDEP
> +#if (defined(DEBUG) || defined(XFS_WARN)) && CONFIG_LOCKDEP
>
> is how I fixed it.
>
Sounds good to me.
Brian
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-08-21 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 10:23 [PATCH] xfs: inode lockdep annotations broke non-lockdep build Dave Chinner
2015-08-19 22:50 ` Eric Sandeen
2015-08-20 11:32 ` Brian Foster
2015-08-21 0:42 ` Dave Chinner
2015-08-21 11:09 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821110906.GA46372@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox