From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data
Date: Wed, 26 Aug 2015 08:52:01 +1000 [thread overview]
Message-ID: <20150825225201.GJ714@dastard> (raw)
In-Reply-To: <55DCB52D.3030809@sandeen.net>
On Tue, Aug 25, 2015 at 01:34:21PM -0500, Eric Sandeen wrote:
> Here's another one where we miss setting da_args->geo:
>
> longform_dir2_entry_check_data
> struct xfs_da_args da = {
> .dp = ip,
> // .geo is unset
> };
> ...
> libxfs_dir2_data_make_free(&da ...)
> xfs_dir2_data_make_free
> endptr = (char *)hdr + args->geo->blksize;
> BOOM
>
> Addresses-Coverity-Id: 1298008
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Have to wonder if there are more of these :(
A quick git grep shows 3 uses of the struct xfs_da_args outside
libxfs. longform_dir2_entry_check() is already fixed, this fixes
longform_dir2_entry_check_data(), and dir2_kill_block() still needs
fixing.
AFAICT all the libxfs/ usage is good.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-08-25 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 18:34 [PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data Eric Sandeen
2015-08-25 22:52 ` Dave Chinner [this message]
2015-08-25 22:53 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825225201.GJ714@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox