From: Brian Foster <bfoster@redhat.com>
To: Lucas Stach <dev@lynxeye.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: add mssing inode cache attempts counter increment
Date: Mon, 31 Aug 2015 14:19:32 -0400 [thread overview]
Message-ID: <20150831181931.GB16371@bfoster.bfoster> (raw)
In-Reply-To: <1440702261-3018-1-git-send-email-dev@lynxeye.de>
On Thu, Aug 27, 2015 at 09:04:21PM +0200, Lucas Stach wrote:
> Increasing the inode cache attempt counter was apparently dropped while
> refactoring the cache code and so stayed at the initial 0 value. Add the
> increment back to make the runtime stats more useful.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
Heh, this goes back to:
bf90424 [XFS] Combine the XFS and Linux inodes
... from 2008. :)
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_icache.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 76a9f27..0a326bd 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -412,6 +412,8 @@ xfs_iget(
> if (!ino || XFS_INO_TO_AGNO(mp, ino) >= mp->m_sb.sb_agcount)
> return -EINVAL;
>
> + XFS_STATS_INC(xs_ig_attempts);
> +
> /* get the perag structure and ensure that it's inode capable */
> pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ino));
> agino = XFS_INO_TO_AGINO(mp, ino);
> --
> 2.4.3
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-08-31 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 19:04 [PATCH] xfs: add mssing inode cache attempts counter increment Lucas Stach
2015-08-31 18:19 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831181931.GB16371@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=dev@lynxeye.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox