Re: [PATCH 02/11] xfsprogs: avoid dependency on linux XATTR_SIZE/LIST_MAX

Jan Tulak
2015-09-01T08:35:59Z

[-- Attachment #1.1: Type: text/plain, Size: 1426 bytes --]

Ah, never mind, I noticed I didn't read the last part of Dave's email. It
looks clear now.

Jan

On Tue, Sep 1, 2015 at 10:13 AM, Jan Tulak <jtulak@redhat.com> wrote:

> On Mon, Aug 31, 2015 at 8:58 PM, Christoph Hellwig <hch@infradead.org>
> wrote:
>
>> > index b1c0c10..d532f44 100644
>> > --- a/libhandle/handle.c
>> > +++ b/libhandle/handle.c
>> > @@ -21,6 +21,8 @@
>> > #include "xfs.h"
>> > #include "handle.h"
>> > #include "parent.h"
>> > +#include "xfs/xfs_arch.h"
>> > +#include "xfs/xfs_format.h"
>>
>> These headers should not be used in libhandle. As mentioned last time I
>> think libhandle should get it's own LIBHANDLE_XATTR_LIST_MAX define,
>> separate frome the one for the on disk format.
>>
>
> ​Well, you wrote about adding it into xfs_format.h. I don't recall (and
> can't find) anything else regarding XATTR_SIZE...
>
> > Eww, looks like we depend on these Linux values in the on disk
> > defintion. I think we need to add new XFS_XATTR_SIZE_MAX and
> > XFS_XATTR_LIST_MAX defintions to xfs_format.h and use them where
> > we currently use these.
>
> So ​
>
> ​the XFS_ defines in xfs_format​.h should be there, I just need to add
> another LIBHANDLE_ variant so we don't include the headers, right?
>
> ​Cheers,
> Jan​
>
>
>
>
> --
> Jan Tulak
> jtulak@redhat.com / jan@tulak.me
>

--
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 4535 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]