Re: [PATCH v2] xfsprogs: add nftw64 translation for OS X

Jan Tulak
2015-09-02T07:12:28Z

[-- Attachment #1.1: Type: text/plain, Size: 1080 bytes --]

On Tue, Sep 1, 2015 at 6:31 PM, Darrick J. Wong <darrick.wong@oracle.com>
wrote:

> On Tue, Sep 01, 2015 at 10:04:32AM +0200, Jan Tulak wrote:
> > UPDATE: changed to #define
> >
> > OS X has only nftw variant - not the 64 suffix used in xfs.
> >
> > Signed-off-by: Jan Tulak <jtulak@redhat.com>
> > ---
> > include/darwin.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/darwin.h b/include/darwin.h
> > index 72d9c1d..f0f05b3 100644
> > --- a/include/darwin.h
> > +++ b/include/darwin.h
> > @@ -157,6 +157,8 @@ typedef int64_t xfs_daddr_t;
> >
> > #define HAVE_FID 1
> >
> > +#define nftw64 nftw
> > +
>
> Sorry for chiming in late, but there's only one caller of nftw64 and
> several
> callers of nftw; why not just change it to use nftw?
>
> <shrug> There could be other reasons why xfs_estimate requires the -64
> variant, but I don't know. :)
>

​Good idea. I'll run tests after the change​

​and if nothing bad happens, I send
it here.
​
--
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 2284 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]