Re: [PATCH 10/11] xfsprogs: add dummy mntent for OS X

Jan Tulak
2015-09-03T10:37:44Z

[-- Attachment #1.1: Type: text/plain, Size: 1313 bytes --]

On Thu, Sep 3, 2015 at 12:33 PM, Dave Chinner <david@fromorbit.com> wrote:

> On Thu, Sep 03, 2015 at 11:01:44AM +0200, Jan Tulak wrote:
> > On Mon, Aug 31, 2015 at 9:01 PM, Christoph Hellwig <hch@infradead.org>
> > wrote:
> >
> > > On Wed, Aug 26, 2015 at 02:02:34PM +0200, Jan Tulak wrote:
> > > > Because these calls are used only by xfs_fsr, which can't
> > > > work on OS X unless a way how to mount XFS is found,
> > > > there is not use in implementing these calls.
> > >
> > > Take a look at the quota code for the BSD alternative to mntent.
> > > That code should be moved into a common location and used by fsr.
> > >
> >
> > ​I tried to find it, but didn't found... Could you point me where it is?
> > Quota/freebsd.h has just few lines with one definition with errno =
> > -ENOSYS, and in other files in quota/, I didn't saw anything BSD
> specific.
>
> I think Christoph is refering to the code in libxcmd/paths.c:
>
> #if defined(HAVE_GETMNTENT)
> ....
> #elif defined(HAVE_GETMNTINFO)
> ....
> #else
> # error "How do I extract info about mounted filesystems on this platform?"
> #endif
> #
>
> HAVE_GETMNTINFO is for BSD systems, IIRC.
>
>
​All right, I will look on this. Thanks. :-)

Cheers,
Jan​

--
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 2567 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]