Re: [PATCH 50/58] xfs: reflink extents from one file to another

kbuild test robot
2015-10-07T05:14:09Z

[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]

Hi Darrick,

[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: sh-titan_defconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

fs/xfs/xfs_reflink.c: In function 'remap_blocks':
>> fs/xfs/xfs_reflink.c:1385:2: warning: 'error' may be used uninitialized in this function [-Wuninitialized]

vim +/error +1385 fs/xfs/xfs_reflink.c

1369 */
1370 if (imap.br_startblock == HOLESTARTBLOCK ||
1371 imap.br_startblock == DELAYSTARTBLOCK ||
1372 ISUNWRITTEN(&imap))
1373 goto advloop;
1374
1375 error = remap_one_range(dest, &imap, destoff + srcioff);
1376 if (error)
1377 break;
1378 advloop:
1379 /* Advance drange/srange */
1380 srcoff += srcioff + imap.br_blockcount;
1381 destoff += srcioff + imap.br_blockcount;
1382 len -= srcioff + imap.br_blockcount;
1383 }
1384
> 1385 return error;
1386 }
1387 #undef IMAPNEXT
1388
1389 /**
1390 * xfs_reflink() - link a range of blocks from one inode to another
1391 *
1392 * @src: Inode to clone from
1393 * @srcoff: Offset within source to start clone from

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 15297 bytes --]

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]