From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/5] xfs_repair: fix unaligned accesses
Date: Tue, 13 Oct 2015 11:35:07 +1100 [thread overview]
Message-ID: <20151013003507.GK27164@dastard> (raw)
In-Reply-To: <20151009200822.GG27982@bfoster.bfoster>
On Fri, Oct 09, 2015 at 04:08:22PM -0400, Brian Foster wrote:
> On Fri, Oct 09, 2015 at 02:51:09PM -0500, Eric Sandeen wrote:
> > This fixes some unaligned accesses spotted by libubsan in repair.
> >
> > See Documentation/unaligned-memory-access.txt in the kernel
> > tree for why these can be a problem.
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> > ---
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
....
> > @@ -960,15 +960,17 @@ _("bad numrecs 0 in inode %" PRIu64 " bmap btree root block\n"),
> > * btree, we'd do it right here. For now, if there's a
> > * problem, we'll bail out and presumably clear the inode.
> > */
> > - if (!verify_dfsbno(mp, be64_to_cpu(pp[i]))) {
> > - do_warn(_("bad bmap btree ptr 0x%llx in ino %" PRIu64 "\n"),
> > - (unsigned long long) be64_to_cpu(pp[i]), lino);
> > + if (!verify_dfsbno(mp, get_unaligned_be64(&pp[i]))) {
> > + do_warn(
> > +("bad bmap btree ptr 0x%" PRIx64 " in ino %" PRIu64 "\n"),
> > + get_unaligned_be64(&pp[i]), lino);
drops the "_" from the translation string. I'll fix it on commit.
/me can't help but think that a local variable or two would make
this code so much more readable....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-10-13 0:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 19:48 [PATCH 0/5 V2] fix (mostly) minor nits spotted by gcc sanitization Eric Sandeen
2015-10-09 19:49 ` [PATCH 1/5] libxfs: avoid negative (and full-width) shifts in radix-tree.c Eric Sandeen
2015-10-09 19:51 ` [PATCH 2/5] xfs_repair: fix unaligned accesses Eric Sandeen
2015-10-09 20:08 ` Brian Foster
2015-10-13 0:35 ` Dave Chinner [this message]
2015-10-09 19:52 ` [PATCH 3/5] xfs_logprint: fix some " Eric Sandeen
2015-10-09 20:08 ` Brian Foster
2015-10-09 19:53 ` [PATCH 4/5] xfs_metadump: Fix " Eric Sandeen
2015-10-09 20:08 ` Brian Foster
2015-10-09 19:53 ` [PATCH 5/5] xfs_repair: fix left-shift overflows Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013003507.GK27164@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox