From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] headers: remove definition of ASSERT from xfs.h
Date: Thu, 15 Oct 2015 22:35:04 -0700 [thread overview]
Message-ID: <20151016053504.GA22243@infradead.org> (raw)
In-Reply-To: <1444952814-13063-1-git-send-email-david@fromorbit.com>
On Fri, Oct 16, 2015 at 10:46:54AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> If we define ASSERT() in the installed xfs.h header file, programs
> including this header file will have their local definitions of
> ASSERT screwed up. This is something internal to the xfsprogs build,
> so move it to platform_defs.h.in where it will no longer be public.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-10-16 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 23:46 [PATCH] headers: remove definition of ASSERT from xfs.h Dave Chinner
2015-10-16 5:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016053504.GA22243@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox