From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id BD59E7F5F for ; Tue, 27 Oct 2015 00:31:40 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 92C9A8F8037 for ; Mon, 26 Oct 2015 22:31:37 -0700 (PDT) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id h15QJuYwQ3PQ5lvE for ; Mon, 26 Oct 2015 22:31:34 -0700 (PDT) Date: Tue, 27 Oct 2015 16:30:45 +1100 From: Dave Chinner Subject: Re: Inconsistencies with trusted.SGI_ACL_{FILE,DEFAULT} Message-ID: <20151027053045.GL8773@dastard> References: <20151024125659.GA8095@bfoster.bfoster> <20151024152254.GA22232@bfoster.bfoster> <20151026213228.GI8773@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Andreas Gruenbacher Cc: Brian Foster , xfs@oss.sgi.com On Tue, Oct 27, 2015 at 12:52:10AM +0100, Andreas Gruenbacher wrote: > On Mon, Oct 26, 2015 at 10:32 PM, Dave Chinner wrote: > > Really, I'm struggling to understand what the problem is with XFS > > doing translation to it's own special xattr names for ACLs > > underneath the posix layer. > > Right now, setting one of the SGI_ACL attributes leads to stale i_acl > / i_default_acl fields and in the case of SGI_ACL_FILE, possibly to > outdated permissions in i_mode. You would get different information > from getfacl than what's stored on disk. That's because we're not marking the cached acl as stale when setting the acl directly... > > Yes, there's a caching issue when someone directly manipulates > > the underlying xattr, > > "Directly manipulating" could be doing a setxattr of an attribute that > was previously retrieved by getxattr, like restoring a backup. Sure, that's what xfsdump/restore effectively does. > > but you need root to shoot yourself in the foot that way, and that is easily > > solveable. > > What do you mean, it's easily solvable? forget_all_cached_acls() Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs