From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_io: implement 'inode' command V3
Date: Wed, 28 Oct 2015 11:59:24 +1100 [thread overview]
Message-ID: <20151028005924.GP19199@dastard> (raw)
In-Reply-To: <20151023092946.GA752@redhat.com>
On Fri, Oct 23, 2015 at 11:29:46AM +0200, Carlos Maiolino wrote:
> Thanks for the review Brian, I'll walk over it and fix the points you mentioned.
> >
> >
> > I still don't really get why we have separate -l and -s options here. It
> > seems to me that the behavior of -l already gives us the information
> > that -s does. Even if that's not obvious enough, the -l command could
> > just print out both. For example:
> >
> > "Largest inode: 1234 (32-bit)"
>
> I agree with you here, but, I'll let Dave answer this question, maybe he had
> some another idea for it that I'm not aware of.
No preference here; all that I was suggesting was that if you want
to know whether inodes are 32/64 bit it doesn't matter what the
largest inode number is.
i.e. "Can I mount this with inode32 and have no problems (yes/no)?"
And it's a lot easier to just query for *any* 64 bit inode than it
is to find the largest inode number...
If you want to combine the two, then that's fine by me.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-10-28 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:31 [PATCH] xfs_io: implement 'inode' command V3 Carlos Maiolino
2015-10-22 14:42 ` Brian Foster
2015-10-23 9:29 ` Carlos Maiolino
2015-10-28 0:59 ` Dave Chinner [this message]
2015-10-30 15:17 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028005924.GP19199@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox