From: Dave Chinner <david@fromorbit.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH v2 0/5] xfs: SGI ACL Fixes
Date: Mon, 2 Nov 2015 13:53:52 +1100 [thread overview]
Message-ID: <20151102025352.GY19199@dastard> (raw)
In-Reply-To: <1446217508-22157-1-git-send-email-agruenba@redhat.com>
On Fri, Oct 30, 2015 at 04:05:03PM +0100, Andreas Gruenbacher wrote:
> Here is a reworked patch queue that also handles setting SGI_ACL_{FILE,DEFAULT}
> via XFS_IOC_ATTRMULTI_BY_HANDLE. Please review.
>
> Thanks,
> Andreas
>
> Andreas Gruenbacher (5):
> xfs: Validate the length of on-disk ACLs
> xfs: Plug memory leak in xfs_attrmulti_attr_set
Ok, I've taken these two patches for the upcoming merge window as
they fix bugs, but I've taken Brian's cached ACL invalidation patch
instead of these:
> xfs: SGI ACLs: Fix caching and mode setting
> xfs: Add namespace parameter to the xfs kuid/kgid <=> uid/gid wrappers
> xfs: SGI ACLs: Map uid/gid namespaces
I'm not yet convinced that these patches are the right way to solve
the given issue as they may interact badly with xfsdump/restore.
However, I do want the kernel code to behave correctly after
xfs_restore runs and Brian's change is enough to do this. If
we do decide that we need to make the above changes to the posix
acl code, it's easy enough to replace this invalidation code.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-11-02 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 15:05 [PATCH v2 0/5] xfs: SGI ACL Fixes Andreas Gruenbacher
2015-10-30 15:05 ` [PATCH v2 1/5] xfs: Validate the length of on-disk ACLs Andreas Gruenbacher
2015-10-30 15:05 ` [PATCH v2 2/5] xfs: Plug memory leak in xfs_attrmulti_attr_set Andreas Gruenbacher
2015-10-30 15:05 ` [PATCH v2 3/5] xfs: SGI ACLs: Fix caching and mode setting Andreas Gruenbacher
2015-10-30 15:05 ` [PATCH v2 4/5] xfs: Add namespace parameter to the xfs kuid/kgid <=> uid/gid wrappers Andreas Gruenbacher
2015-10-30 15:05 ` [PATCH v2 5/5] xfs: SGI ACLs: Map uid/gid namespaces Andreas Gruenbacher
2015-11-02 2:53 ` Dave Chinner [this message]
2015-11-02 3:41 ` [PATCH v2 0/5] xfs: SGI ACL Fixes Andreas Gruenbacher
2015-11-02 12:20 ` Dave Chinner
2015-11-02 19:52 ` Andreas Gruenbacher
2015-11-02 19:52 ` [PATCH 1/2] xfs: Fixes to "invalidate cached acl if set directly via xattr" Andreas Gruenbacher
2015-11-02 19:52 ` [PATCH 2/2] xfs: invalidate cached acl if set via ioctl Andreas Gruenbacher
2015-11-03 2:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102025352.GY19199@dastard \
--to=david@fromorbit.com \
--cc=agruenba@redhat.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox