Re: [PATCH 4/6] xfs: DAX does not use IO completion callbacks

Dave Chinner
2015-10-29T23:39:35Z

On Thu, Oct 29, 2015 at 10:29:57AM -0400, Brian Foster wrote:
> On Mon, Oct 19, 2015 at 02:27:16PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > For DAX, we are now doing block zeroing and
> > we are updating the file size during allocation. This means we no
> > longer need an IO completion callback to do these things, so remove
> > the completion callbacks from the __dax_fault and __dax_mkwrite
> > calls.
> >
>
> Where do we "update the file size during allocation?"

Stale comment. For page faults, we'll never update the file size
(segv if fault is beyond EOF), and DIO still does IO completion
based file size updates.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com