From: Chris Mason <clm@fb.com>
To: Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, Tejun Heo <htejun@fb.com>
Subject: Re: [PATCH RFC] use WQ_MEM_RECLAIM for m_log_workqueue
Date: Thu, 5 Nov 2015 07:10:59 -0500 [thread overview]
Message-ID: <20151105121059.GJ5458@ret.masoncoding.com> (raw)
In-Reply-To: <20151104185103.GC5458@ret.masoncoding.com>
On Wed, Nov 04, 2015 at 01:51:03PM -0500, Chris Mason wrote:
> I think we should be using WQ_MEM_RECLAIM to make sure this thread pool
> makes progress when we're not able to allocate new workers.
Thinking harder, it's probably best to just flag them all
WQ_MEM_RECLAIM. This is what btrfs does, and it saves you from painful
discoveries about how different queues depend on each other.
Tejun did verify in the dump that progress on m_log_workqueue was stuck
waiting for more threads.
I'll start testing and send a v2.
-chris
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-11-05 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 18:51 [PATCH RFC] use WQ_MEM_RECLAIM for m_log_workqueue Chris Mason
2015-11-05 12:10 ` Chris Mason [this message]
2015-11-08 21:16 ` Dave Chinner
2015-11-10 18:01 ` [PATCH v2] xfs: " Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105121059.GJ5458@ret.masoncoding.com \
--to=clm@fb.com \
--cc=david@fromorbit.com \
--cc=htejun@fb.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox