From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH V2] xfs: create helper for bmap finish & trans join in attr code
Date: Fri, 13 Nov 2015 07:12:31 +1100 [thread overview]
Message-ID: <20151112201231.GS19199@dastard> (raw)
In-Reply-To: <20151112165801.GA14854@infradead.org>
On Thu, Nov 12, 2015 at 08:58:01AM -0800, Christoph Hellwig wrote:
> I think the problem here is simply that our interfaces suck.
> xfs_trans_roll really needs to rejoin any inode to the new transaction
> to that was joined to the previous one. Once we've fixed that we can
> get rid of the silly committed arguments and everyone will be happy.
xfs_trans_roll is not specifically for rolling transactions with
locked inodes in them. We could use it for any object that needs
multiple transactions to modify. e.g. we could roll transactions
across an AGF (using hold+join) so that it remains locked across
multiple allocation/free transactions.
So I think pushing the inode joining inside xfs_trans_roll() is not
the right thing to do, but an "inode specific wrapper" such as
"xfs_trans_roll_inode()" would handle this just fine...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-11-12 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 4:54 [PATCH] xfs: create helper for bmap finish & trans join in xfs_attr.c Eric Sandeen
2015-11-12 4:58 ` Eric Sandeen
2015-11-12 16:31 ` [PATCH V2] xfs: create helper for bmap finish & trans join in attr code Eric Sandeen
2015-11-12 16:58 ` Christoph Hellwig
2015-11-12 20:12 ` Dave Chinner [this message]
2015-11-13 9:08 ` Christoph Hellwig
2015-11-13 21:29 ` Eric Sandeen
2016-01-04 3:58 ` Dave Chinner
2016-01-05 19:01 ` [PATCH V3] xfs: eliminate committed arg from xfs_bmap_finish Eric Sandeen
2016-01-06 3:28 ` Dave Chinner
2016-01-06 4:01 ` [PATCH V4] " Eric Sandeen
2016-01-06 5:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112201231.GS19199@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox