Question on how to submit changed code

Question on how to submit changed code

[Epp, Mike]

[-- Attachment #1.1: Type: text/plain, Size: 1593 bytes --]

I have changed code in libxfs and repair projects for xfsprogs.  I don't view the changes as desired for ongoing deployment, as they allowed scanning of active volumes and bring the chance of false errors.  To stay compliant with GNU GPL though we must publish the code.  What are the steps I need to follow to publish the changes?  Do I need to publish just the source files I changed, the entire projects I changes, or all of xfsprogs?

Mike Epp, Senior Software Engineer
Kroll Ontrack |  9023 Columbine Road, Eden Prairie, MN 55347
mepp@krollontrack.com<mailto:mepp@krollontrack.com>
www.krollontrack.com<http://www.krollontrack.com/ohttp:/www.krollontrack.com/>
This communication contains information that is confidential, proprietary in nature, and may also be attorney-client privileged and/or work product privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) or the person responsible for delivering it to the intended recipient(s), please note that any form of dissemination, distribution or copying of this communication is strictly prohibited and may be unlawful. If you have received this communication in error, please immediately notify the sender and delete the original communication. Thank you for your cooperation.
Please be advised that neither Kroll, its affiliates, its employees or agents accept liability for any errors, omissions or damages caused by delays of receipt or by any virus infection in this message or its attachments, or which may otherwise arise as a result of this e-mail transmission.


[-- Attachment #1.2: Type: text/html, Size: 4708 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Carlos Maiolino]

I'm not an attorney, so take my suggestions with some caution.

If you want to publish the code for be compliant with GPL, you might want to use
some public repository like github, sourceforge, etc. but I think that even
sending the patch to the list would be enough.

Although, I think you only violate GPL if you're distributing the executables
without the source code.

But, I'm not the best GPL geek, so I might be wrong




On Tue, Dec 01, 2015 at 03:16:11PM +0000, Epp, Mike wrote:
>    I have changed code in libxfs and repair projects for xfsprogs.  I
>    don’t view the changes as desired for ongoing deployment, as they
>    allowed scanning of active volumes and bring the chance of false
>    errors.  To stay compliant with GNU GPL though we must publish the
>    code.  What are the steps I need to follow to publish the changes?  Do
>    I need to publish just the source files I changed, the entire projects
>    I changes, or all of xfsprogs?
> 
> 
>    Mike Epp, Senior Software Engineer
> 
>    Kroll Ontrack |  9023 Columbine Road, Eden Prairie, MN 55347
>    [1]mepp@krollontrack.com
>    [2]www.krollontrack.com
> 
>    This communication contains information that is confidential,
>    proprietary in nature, and may also be attorney-client privileged
>    and/or work product privileged. It is for the exclusive use of the
>    intended recipient(s). If you are not the intended recipient(s) or the
>    person responsible for delivering it to the intended recipient(s),
>    please note that any form of dissemination, distribution or copying of
>    this communication is strictly prohibited and may be unlawful. If you
>    have received this communication in error, please immediately notify
>    the sender and delete the original communication. Thank you for your
>    cooperation.
> 
>    Please be advised that neither Kroll, its affiliates, its employees or
>    agents accept liability for any errors, omissions or damages caused by
>    delays of receipt or by any virus infection in this message or its
>    attachments, or which may otherwise arise as a result of this e-mail
>    transmission.
> 
> References
> 
>    1. mailto:mepp@krollontrack.com
>    2. http://www.krollontrack.com/ohttp:/www.krollontrack.com/

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs


-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Bill O'Donnell]

On Tue, Dec 01, 2015 at 05:33:35PM +0100, Carlos Maiolino wrote:
> I'm not an attorney, so take my suggestions with some caution.
> 
> If you want to publish the code for be compliant with GPL, you might want to use
> some public repository like github, sourceforge, etc. but I think that even
> sending the patch to the list would be enough.
> 
> Although, I think you only violate GPL if you're distributing the executables
> without the source code.

That's my understanding as well. I'd recommend submitting the patches to the list.
Even if they're NACKed, they're essentially "published". That said, if you have
other executables that are part of the offering, but are not public, you'd need
to make that source code public too.

> 
> But, I'm not the best GPL geek, so I might be wrong
> 
ditto. YMMV, so I'd consult a legal eagle.  :P.

Bill
> 
> 
> On Tue, Dec 01, 2015 at 03:16:11PM +0000, Epp, Mike wrote:
> >    I have changed code in libxfs and repair projects for xfsprogs.  I
> >    don’t view the changes as desired for ongoing deployment, as they
> >    allowed scanning of active volumes and bring the chance of false
> >    errors.  To stay compliant with GNU GPL though we must publish the
> >    code.  What are the steps I need to follow to publish the changes?  Do
> >    I need to publish just the source files I changed, the entire projects
> >    I changes, or all of xfsprogs?
> > 
> > 
> >    Mike Epp, Senior Software Engineer
> > 
> >    Kroll Ontrack |  9023 Columbine Road, Eden Prairie, MN 55347
> >    [1]mepp@krollontrack.com
> >    [2]www.krollontrack.com
> > 
> >    This communication contains information that is confidential,
> >    proprietary in nature, and may also be attorney-client privileged
> >    and/or work product privileged. It is for the exclusive use of the
> >    intended recipient(s). If you are not the intended recipient(s) or the
> >    person responsible for delivering it to the intended recipient(s),
> >    please note that any form of dissemination, distribution or copying of
> >    this communication is strictly prohibited and may be unlawful. If you
> >    have received this communication in error, please immediately notify
> >    the sender and delete the original communication. Thank you for your
> >    cooperation.
> > 
> >    Please be advised that neither Kroll, its affiliates, its employees or
> >    agents accept liability for any errors, omissions or damages caused by
> >    delays of receipt or by any virus infection in this message or its
> >    attachments, or which may otherwise arise as a result of this e-mail
> >    transmission.
> > 
> > References
> > 
> >    1. mailto:mepp@krollontrack.com
> >    2. http://www.krollontrack.com/ohttp:/www.krollontrack.com/
> 
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
> 
> 
> -- 
> Carlos
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Roger Willcocks]

On Tue, 2015-12-01 at 15:16 +0000, Epp, Mike wrote:
> I have changed code in libxfs and repair projects for xfsprogs.  I
> don’t view the changes as desired for ongoing deployment, as they
> allowed scanning of active volumes and bring the chance of false
> errors.  To stay compliant with GNU GPL though we must publish the
> code.  What are the steps I need to follow to publish the changes?  Do
> I need to publish just the source files I changed, the entire projects
> I changes, or all of xfsprogs?
> 

You don't need to publish the code but you do need to make a full copy
of the code, including your clearly marked changes, available to your
customers.

See GPL section 3.

>  
> 
> Mike Epp, Senior Software Engineer
> 
> Kroll Ontrack |  9023 Columbine Road, Eden Prairie, MN 55347
> mepp@krollontrack.com
> www.krollontrack.com

--
Roger




_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Carlos Maiolino]

On Tue, Dec 01, 2015 at 05:41:00PM +0000, Roger Willcocks wrote:
> 
> On Tue, 2015-12-01 at 15:16 +0000, Epp, Mike wrote:
> > I have changed code in libxfs and repair projects for xfsprogs.  I
> > don’t view the changes as desired for ongoing deployment, as they
> > allowed scanning of active volumes and bring the chance of false
> > errors.  To stay compliant with GNU GPL though we must publish the
> > code.  What are the steps I need to follow to publish the changes?  Do
> > I need to publish just the source files I changed, the entire projects
> > I changes, or all of xfsprogs?
> > 
> 
> You don't need to publish the code but you do need to make a full copy
> of the code, including your clearly marked changes, available to your
> customers.
> 
> See GPL section 3.

Just FYI, xfsprogs is licensed under GPL V2, not V3, they are different in many
aspects.

> 
> >  
> > 
> > Mike Epp, Senior Software Engineer
> > 
> > Kroll Ontrack |  9023 Columbine Road, Eden Prairie, MN 55347
> > mepp@krollontrack.com
> > www.krollontrack.com
> 
> --
> Roger
> 
> 
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Carlos Maiolino]

> > See GPL section 3.
> 
> Just FYI, xfsprogs is licensed under GPL V2, not V3, they are different in many
> aspects.
> 
NVM, I misread section 3 as 'version' 3, I think I should get some sleep.


> > 
> > >  
> > > 
> > > Mike Epp, Senior Software Engineer
> > > 
> > > Kroll Ontrack |  9023 Columbine Road, Eden Prairie, MN 55347
> > > mepp@krollontrack.com
> > > www.krollontrack.com
> > 
> > --
> > Roger
> > 
> > 
> > 
> > 
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
> 
> -- 
> Carlos
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Roger Willcocks]

On Tue, 2015-12-01 at 18:44 +0100, Carlos Maiolino wrote:
> On Tue, Dec 01, 2015 at 05:41:00PM +0000, Roger Willcocks wrote:
> > 
> > On Tue, 2015-12-01 at 15:16 +0000, Epp, Mike wrote:
> > > I have changed code in libxfs and repair projects for xfsprogs.  I
> > > don’t view the changes as desired for ongoing deployment, as they
> > > allowed scanning of active volumes and bring the chance of false
> > > errors.  To stay compliant with GNU GPL though we must publish the
> > > code.  What are the steps I need to follow to publish the changes?  Do
> > > I need to publish just the source files I changed, the entire projects
> > > I changes, or all of xfsprogs?
> > > 
> > 
> > You don't need to publish the code but you do need to make a full copy
> > of the code, including your clearly marked changes, available to your
> > customers.
> > 
> > See GPL section 3.
> 
> Just FYI, xfsprogs is licensed under GPL V2, not V3, they are different in many
> aspects.
> 

xfsprogs source code (e.g. xfs_dir2_node.c) says:

 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 * published by the Free Software Foundation.

which probably makes it V1.

http://linux-xfs.oss.sgi.narkive.com/drJRUsIn/xfsprogs-xfsdump-what-flavor-of-gpl

--
Roger


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

RE: Question on how to submit changed code

[Epp, Mike]

From the "COPYING" file under docs:

The library named "libhandle" and some specific header files (including
<xfs/xfs.h>) are licensed under the GNU Lesser General Public License.

All other components are licensed under the GNU General Public License.

----------------------------------------------------------------------


<http://www.fsf.org/copyleft/lesser.txt>

		  GNU LESSER GENERAL PUBLIC LICENSE
		       Version 2.1, February 1999

-----Original Message-----
From: Roger Willcocks [mailto:roger@filmlight.ltd.uk] 
Sent: Tuesday, December 01, 2015 12:03 PM
To: Carlos Maiolino
Cc: Epp, Mike; xfs@oss.sgi.com
Subject: Re: Question on how to submit changed code


On Tue, 2015-12-01 at 18:44 +0100, Carlos Maiolino wrote:
> On Tue, Dec 01, 2015 at 05:41:00PM +0000, Roger Willcocks wrote:
> > 
> > On Tue, 2015-12-01 at 15:16 +0000, Epp, Mike wrote:
> > > I have changed code in libxfs and repair projects for xfsprogs.  I 
> > > don’t view the changes as desired for ongoing deployment, as they 
> > > allowed scanning of active volumes and bring the chance of false 
> > > errors.  To stay compliant with GNU GPL though we must publish the 
> > > code.  What are the steps I need to follow to publish the changes?  
> > > Do I need to publish just the source files I changed, the entire 
> > > projects I changes, or all of xfsprogs?
> > > 
> > 
> > You don't need to publish the code but you do need to make a full 
> > copy of the code, including your clearly marked changes, available 
> > to your customers.
> > 
> > See GPL section 3.
> 
> Just FYI, xfsprogs is licensed under GPL V2, not V3, they are 
> different in many aspects.
> 

xfsprogs source code (e.g. xfs_dir2_node.c) says:

 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 * published by the Free Software Foundation.

which probably makes it V1.

http://linux-xfs.oss.sgi.narkive.com/drJRUsIn/xfsprogs-xfsdump-what-flavor-of-gpl

--
Roger


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Dave Chinner]

On Tue, Dec 01, 2015 at 06:03:23PM +0000, Roger Willcocks wrote:
> 
> On Tue, 2015-12-01 at 18:44 +0100, Carlos Maiolino wrote:
> > On Tue, Dec 01, 2015 at 05:41:00PM +0000, Roger Willcocks wrote:
> > > 
> > > On Tue, 2015-12-01 at 15:16 +0000, Epp, Mike wrote:
> > > > I have changed code in libxfs and repair projects for xfsprogs.  I
> > > > don’t view the changes as desired for ongoing deployment, as they
> > > > allowed scanning of active volumes and bring the chance of false
> > > > errors.  To stay compliant with GNU GPL though we must publish the
> > > > code.  What are the steps I need to follow to publish the changes?  Do
> > > > I need to publish just the source files I changed, the entire projects
> > > > I changes, or all of xfsprogs?
> > > > 
> > > 
> > > You don't need to publish the code but you do need to make a full copy
> > > of the code, including your clearly marked changes, available to your
> > > customers.
> > > 
> > > See GPL section 3.
> > 
> > Just FYI, xfsprogs is licensed under GPL V2, not V3, they are different in many
> > aspects.
> > 
> 
> xfsprogs source code (e.g. xfs_dir2_node.c) says:
> 
>  * This program is free software; you can redistribute it and/or
>  * modify it under the terms of the GNU General Public License as
>  * published by the Free Software Foundation.
> 
> which probably makes it V1.

Please do not make guesses when it comes to the code licenses
because they are probably wrong.  That file is most definitely GPL
v2, because it is a direct copy of the kernel code...

> http://linux-xfs.oss.sgi.narkive.com/drJRUsIn/xfsprogs-xfsdump-what-flavor-of-gpl

Just to clarify xfsprogs from various license statements and
requirements. From doc/VERSIONS and debian/copyright:

	The library named "libhandle" and the headers in "xfslibs-dev" are
	licensed under Version 2.1 of the GNU Lesser General Public License.

From other files:

libxfs/radix_tree.c, include/radix_tree.h are GPL v2+

libxfs/* contains direct copies of kernel code and code flows in
both directions, so these must be must be GPL v2 licensed code as
this is what hte kernel is licensed under. The exception here is the
header files that are installed via xfslibs-dev, which means those
files are dual licensed GPLv2/LGPLv2.1.

And since everything else in xfsprogs is statically linked to libxfs
the rest of the code inherits the GPLv2 license of libxfs, and hence
also carry a GPL v2 license.

Hence the best assumption to make is that the xfsprogs source code
code is GPLv2, except where expressly stated to be LGPLv2.1 or
GPLv2+....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Bill O'Donnell]

On Tue, Dec 01, 2015 at 05:41:00PM +0000, Roger Willcocks wrote:
> 
> On Tue, 2015-12-01 at 15:16 +0000, Epp, Mike wrote:
> > I have changed code in libxfs and repair projects for xfsprogs.  I
> > don’t view the changes as desired for ongoing deployment, as they
> > allowed scanning of active volumes and bring the chance of false
> > errors.  To stay compliant with GNU GPL though we must publish the
> > code.  What are the steps I need to follow to publish the changes?  Do
> > I need to publish just the source files I changed, the entire projects
> > I changes, or all of xfsprogs?
> > 
> 
> You don't need to publish the code but you do need to make a full copy
> of the code, including your clearly marked changes, available to your
> customers.
> 
> See GPL section 3.

Ahh, right, thanks.  I recall working on an embedded system that had GPL
code in it, and we just threw a short blurb in the shipping box:
'...this product contains GPL software... for a copy of the source code,
contact the manufacturer...".


> 
> >  
> > 
> > Mike Epp, Senior Software Engineer
> > 
> > Kroll Ontrack |  9023 Columbine Road, Eden Prairie, MN 55347
> > mepp@krollontrack.com
> > www.krollontrack.com
> 
> --
> Roger
> 
> 
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Question on how to submit changed code

[Dave Chinner]

On Tue, Dec 01, 2015 at 03:16:11PM +0000, Epp, Mike wrote:
> I have changed code in libxfs and repair projects for xfsprogs.  I
> don't view the changes as desired for ongoing deployment, as they
> allowed scanning of active volumes and bring the chance of false
> errors.  To stay compliant with GNU GPL though we must publish the
> code.  What are the steps I need to follow to publish the changes?

Many options, but you should really be asking you company's legal
counsel this question.

>From my perspective, either of these would work:

	- add a page to your company's website with a link from the
	  home page that contains the tarballs of modified packages.
	- put the modified source code up in a repository on github
	  (or similar) and include a link from the website
	- send patches to an archived mailing list whenever you
	  change the code, and place a link to the archive on your
	  website home page.

> Do I need to publish just the source files I changed, the entire
> projects I changes, or all of xfsprogs?

-> legal counsel

The license spells out what is necessary. All of the above are valid
interpretations....

> Mike Epp, Senior Software Engineer Kroll Ontrack |  9023 Columbine
> Road, Eden Prairie, MN 55347
> mepp@krollontrack.com<mailto:mepp@krollontrack.com>
> www.krollontrack.com<http://www.krollontrack.com/ohttp:/www.krollontrack.com/>
> This communication contains information that is confidential,
> proprietary in nature, and may also be attorney-client privileged
> and/or work product privileged. It is for the exclusive use of the
> intended recipient(s).

[snip]

And any code you send to the mailing list must have a valid
signed-off-by and not have a bunch of restrictive legal mumbo jumbo
on the end of it....

Cheers,

Dave.

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs