From: Brian Foster <bfoster@redhat.com>
To: Jan Tulak <jtulak@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfsprogs: Removal of trailing whitespaces
Date: Wed, 9 Dec 2015 06:59:00 -0500 [thread overview]
Message-ID: <20151209115900.GA45171@bfoster.bfoster> (raw)
In-Reply-To: <CACj3i73f4_KZ8qUN4Gqz_bg3TCTbgdsg9PZ6UvMSRm+9JHN0JA@mail.gmail.com>
On Tue, Dec 08, 2015 at 07:48:31PM +0100, Jan Tulak wrote:
> Hi,
>
> I decided to remove trailing whitespaces on various locations in the code
> of xfsprogs, mainly because I have enabled highlighting of these, and they
> were flashing into my eyes whenever I scrolled around. :-)
>
> I looked for the last commit touching some of the lines with trailing
> blanks and in all cases I found that the lines were last changed in 2011 or
> earlier. Maybe there can be something newer, I didn't checked the story of
> every one, but it seems that they are here for a long time, and will be
> still if I don't remove them.
>
> Right now, I have 14 patches, one for every tool/directory, where some
> change occurred. About 140 lines changed in 52 files in total. I thought
> that separating it this way makes for easier fix if it causes a conflict
> with some other patch, however I can merge them into a single patch.
>
> Should I send it separated as it is, or merge it into a single patch?
>
A single patch makes for less noise in the commit log, IMO.
Brian
> Cheers,
> Jan
>
> --
> Jan Tulak
> jtulak@redhat.com / jan@tulak.me
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-12-09 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 18:48 xfsprogs: Removal of trailing whitespaces Jan Tulak
2015-12-09 11:59 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209115900.GA45171@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=jtulak@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox