xfsprogs: Removal of trailing whitespaces

xfsprogs: Removal of trailing whitespaces

[Jan Tulak]

[-- Attachment #1.1: Type: text/plain, Size: 956 bytes --]

Hi,

I decided to remove trailing whitespaces on various locations in the code
of xfsprogs, mainly because I have enabled highlighting of these, and they
were flashing into my eyes whenever I scrolled around. :-)

I looked for the last commit touching some of the lines with trailing
blanks and in all cases I found that the lines were last changed in 2011 or
earlier. Maybe there can be something newer, I didn't checked the story of
every one, but it seems that they are here for a long time, and will be
still if I don't remove them.

Right now, I have 14 patches, one for every tool/directory, where some
change occurred. About 140 lines changed in 52 files in total. I thought
that separating it this way makes for easier fix if it causes a conflict
with some other patch, however I can merge them into a single patch.

Should I send it separated as it is, or merge it into a single patch?

Cheers,
Jan

-- 
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 2220 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs: Removal of trailing whitespaces

[Brian Foster]

On Tue, Dec 08, 2015 at 07:48:31PM +0100, Jan Tulak wrote:
> Hi,
> 
> I decided to remove trailing whitespaces on various locations in the code
> of xfsprogs, mainly because I have enabled highlighting of these, and they
> were flashing into my eyes whenever I scrolled around. :-)
> 
> I looked for the last commit touching some of the lines with trailing
> blanks and in all cases I found that the lines were last changed in 2011 or
> earlier. Maybe there can be something newer, I didn't checked the story of
> every one, but it seems that they are here for a long time, and will be
> still if I don't remove them.
> 
> Right now, I have 14 patches, one for every tool/directory, where some
> change occurred. About 140 lines changed in 52 files in total. I thought
> that separating it this way makes for easier fix if it causes a conflict
> with some other patch, however I can merge them into a single patch.
> 
> Should I send it separated as it is, or merge it into a single patch?
> 

A single patch makes for less noise in the commit log, IMO.

Brian

> Cheers,
> Jan
> 
> -- 
> Jan Tulak
> jtulak@redhat.com / jan@tulak.me

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs