public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michał Pecio" <michal.pecio@gmail.com>
To: xfs@oss.sgi.com
Subject: Fixing XFS RAID - does XFS ever issue non-aligned discards?
Date: Tue, 15 Dec 2015 14:16:05 +0100	[thread overview]
Message-ID: <20151215141605.5b60d336@sauron> (raw)

Hi,

I'm using XFS with bsize=4096 on RAID0 of two Intel 320 SSDs under
Linux 3.18 LTS. I'm wondering if it's correct to assume that discards
issued by XFS will always be multiples of 4k and 4k-aligned?

I'm asking because I need to fix damage caused by the infamous RAID0
bug from May 2015, which, if I'm reading the code correctly, basically
permuted discard requests between component disks, i.e. sda discarded
offsets which were supposed to be discarded by sdb and vice-versa.

The only backup I have is very slow so I'm trying to minimize copying.
The list of files with 4k-aligned blocks of zeros is small and worth
reviewing manually, but there is much more files with smaller holes
and I'd like to know if I should be bothered by them. Fwiw, I checked
few and they've all been false positives so far.

Thanks for any help,
MP

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2015-12-15 13:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 13:16 Michał Pecio [this message]
2015-12-15 22:19 ` Fixing XFS RAID - does XFS ever issue non-aligned discards? Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151215141605.5b60d336@sauron \
    --to=michal.pecio@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox