public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* Fixing XFS RAID - does XFS ever issue non-aligned discards?
@ 2015-12-15 13:16 Michał Pecio
  2015-12-15 22:19 ` Dave Chinner
  0 siblings, 1 reply; 2+ messages in thread
From: Michał Pecio @ 2015-12-15 13:16 UTC (permalink / raw)
  To: xfs

Hi,

I'm using XFS with bsize=4096 on RAID0 of two Intel 320 SSDs under
Linux 3.18 LTS. I'm wondering if it's correct to assume that discards
issued by XFS will always be multiples of 4k and 4k-aligned?

I'm asking because I need to fix damage caused by the infamous RAID0
bug from May 2015, which, if I'm reading the code correctly, basically
permuted discard requests between component disks, i.e. sda discarded
offsets which were supposed to be discarded by sdb and vice-versa.

The only backup I have is very slow so I'm trying to minimize copying.
The list of files with 4k-aligned blocks of zeros is small and worth
reviewing manually, but there is much more files with smaller holes
and I'd like to know if I should be bothered by them. Fwiw, I checked
few and they've all been false positives so far.

Thanks for any help,
MP

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fixing XFS RAID - does XFS ever issue non-aligned discards?
  2015-12-15 13:16 Fixing XFS RAID - does XFS ever issue non-aligned discards? Michał Pecio
@ 2015-12-15 22:19 ` Dave Chinner
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2015-12-15 22:19 UTC (permalink / raw)
  To: Michał Pecio; +Cc: xfs

On Tue, Dec 15, 2015 at 02:16:05PM +0100, Michał Pecio wrote:
> Hi,
> 
> I'm using XFS with bsize=4096 on RAID0 of two Intel 320 SSDs under
> Linux 3.18 LTS. I'm wondering if it's correct to assume that discards
> issued by XFS will always be multiples of 4k and 4k-aligned?

Yes. Discards are only done on filesystem blocks, so will have
filesystem block granularity/alignment.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-15 22:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-15 13:16 Fixing XFS RAID - does XFS ever issue non-aligned discards? Michał Pecio
2015-12-15 22:19 ` Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox