From: Dave Chinner <david@fromorbit.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: XFS Developers <xfs@oss.sgi.com>
Subject: Re: [XFSTESTS 5/6] Add richacl tests
Date: Wed, 16 Dec 2015 09:32:01 +1100 [thread overview]
Message-ID: <20151215223201.GQ26718@dastard> (raw)
In-Reply-To: <CAHc6FU5Y91VYLpEbG5zFEwDs+CwWpafJMj4XMRKZgeaUY2m6zA@mail.gmail.com>
On Tue, Dec 15, 2015 at 12:32:10AM +0100, Andreas Gruenbacher wrote:
> It then also makes sense to run all of the richacl tests at once, on
> the same scratch file system, similar to xfs/191.
No, it doesn't. just because I refered you to how some piece of
infrastructure works via a given test, it doesn't mean that
everythign the test does is correct. xfs/191 is a bad test because
it aggregates lots of little regression tests into a single test via
it's own internal harness - exactly the same issues that I'm telling
you know is not acceptible for the richacl tests.
The rule of thumb is that there should be one xfs test per
individual regression test. You've got at least 10 separate
regression tests there, so there should be at least 10 xfstests.
They should not be aggregated into a single test - if you need to
run them all at once, then that is what the richacl test group is
for....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-12-15 22:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 14:17 [XFSTESTS 0/6] Richacl Tests Andreas Gruenbacher
2015-11-18 14:17 ` [XFSTESTS 1/6] check: Don't complain about missing tests/$FSTYP/group Andreas Gruenbacher
2015-11-18 14:17 ` [XFSTESTS 2/6] check: Enforce xfs filesystem recreation on $TEST_DEV Andreas Gruenbacher
2015-12-01 14:43 ` Carlos Maiolino
2015-11-18 14:17 ` [XFSTESTS 3/6] Rename output file templates to match TEST.out* Andreas Gruenbacher
2015-11-18 14:17 ` [XFSTESTS 4/6] check: Add support for tests without *.out files Andreas Gruenbacher
2015-11-18 14:17 ` [XFSTESTS 5/6] Add richacl tests Andreas Gruenbacher
2015-11-23 23:08 ` Dave Chinner
2015-12-03 23:10 ` Andreas Gruenbacher
2015-12-07 21:36 ` Dave Chinner
2015-12-14 23:40 ` Andreas Gruenbacher
2015-12-06 17:31 ` Andreas Gruenbacher
2015-12-07 21:11 ` Dave Chinner
2015-12-07 23:45 ` Andreas Gruenbacher
2015-12-08 6:44 ` Dave Chinner
2015-12-14 23:32 ` Andreas Gruenbacher
2015-12-15 22:32 ` Dave Chinner [this message]
2015-11-18 14:17 ` [XFSTESTS 6/6] Remove the obsolete nfs4acl tests Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215223201.GQ26718@dastard \
--to=david@fromorbit.com \
--cc=agruenba@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox