From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id E6F717F62 for ; Sun, 20 Dec 2015 09:35:18 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id BA012304032 for ; Sun, 20 Dec 2015 07:35:15 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id oET2M7O4tqecQ2eQ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Sun, 20 Dec 2015 07:35:13 -0800 (PST) Date: Sun, 20 Dec 2015 07:35:13 -0800 From: Christoph Hellwig Subject: Re: [PATCH v2 2/4] xfsprogs: fix integer overflow in xlog_find_verify_cycle Message-ID: <20151220153513.GD20135@infradead.org> References: <1449832143-26356-1-git-send-email-t.vivek@samsung.com> <1449832143-26356-3-git-send-email-t.vivek@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1449832143-26356-3-git-send-email-t.vivek@samsung.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Vivek Trivedi Cc: a.sahrawat@samsung.com, pankaj.m@samsung.com, xfs@oss.sgi.com On Fri, Dec 11, 2015 at 04:39:01PM +0530, Vivek Trivedi wrote: > Fix unintentional integer overflow in xlog_find_verify_cycle. > Reported by coverity. xfs_daddr_t is a 64-bit integer. How does replacing it with an int fix overlows? xlog_find_verify_cycle originates in the kernel code, so any fix should probably be done there first. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs