From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH V4] xfs: eliminate committed arg from xfs_bmap_finish
Date: Tue, 5 Jan 2016 21:31:23 -0800 [thread overview]
Message-ID: <20160106053123.GA19935@infradead.org> (raw)
In-Reply-To: <568C917C.9050509@sandeen.net>
Looks great!
Reviewed-by: Christoph Hellwig <hch@lst.de>
Note that the "if (*tpp != tp)" trick also works in xfs_bmap_finish, which
will allows us to fold __xfs_trans_roll into xfs_trans_roll in a follow
on patch.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-01-06 5:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 4:54 [PATCH] xfs: create helper for bmap finish & trans join in xfs_attr.c Eric Sandeen
2015-11-12 4:58 ` Eric Sandeen
2015-11-12 16:31 ` [PATCH V2] xfs: create helper for bmap finish & trans join in attr code Eric Sandeen
2015-11-12 16:58 ` Christoph Hellwig
2015-11-12 20:12 ` Dave Chinner
2015-11-13 9:08 ` Christoph Hellwig
2015-11-13 21:29 ` Eric Sandeen
2016-01-04 3:58 ` Dave Chinner
2016-01-05 19:01 ` [PATCH V3] xfs: eliminate committed arg from xfs_bmap_finish Eric Sandeen
2016-01-06 3:28 ` Dave Chinner
2016-01-06 4:01 ` [PATCH V4] " Eric Sandeen
2016-01-06 5:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106053123.GA19935@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox