From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend
Date: Fri, 8 Jan 2016 02:09:33 -0800 [thread overview]
Message-ID: <20160108100933.GN28330@birch.djwong.org> (raw)
In-Reply-To: <20160107152541.GA16982@lst.de>
On Thu, Jan 07, 2016 at 04:25:42PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 06, 2016 at 04:32:27PM -0800, Darrick J. Wong wrote:
> > Ok. I spent a couple of days trying to find all the places where we need to
> > delete CoW reservations (hole punch, truncate, etc.) and found some places
> > where the code was leaving reservations behind in the CoW fork (most notable
> > truncate). I also made the inode eviction code purge any CoW leftovers, so
> > that should all go away.
>
> Can you send that part out for NFS testing?
Ok, I've uploaded the latest kernel + xfstests to github:
https://github.com/djwong/linux/commits/for-dave
https://github.com/djwong/xfstests/tree/for-dave
(Big pile of new tests to try to exercise the cow cancellation code.)
>
> > I also wrote some more xfstests that try to hit all the CoW-cancelling code
> > paths (fpunch, fzero, fcollapse, finsert, truncate, -EIO) to smoke test all
> > that. By the way, do you have a testcase handy for the "non-blocking writeback
> > EAGAIN" case? I'm guessing that we could hit that pretty easily by lowering
> > dirty_background_* and dirtying a lot of pages while reflinking?
>
> I did hit it pretty easily testing over NFS to a local nfs server with
> xfstests.
Hmm. If my latest round of fixes didn't get this one, I'll see next week if
I can get the NFS stuff working so I can test it directly.
--D
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-01-08 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 12:07 reflink fixes Christoph Hellwig
2016-01-03 12:07 ` [PATCH 1/3] xfs: pass inode instead of file to xfs_reflink_dirty_range Christoph Hellwig
2016-01-05 1:23 ` Darrick J. Wong
2016-01-03 12:07 ` [PATCH 2/3] xfs: only end a COW operation in xfs_zero_remaining_bytes if we started one Christoph Hellwig
2016-01-05 1:28 ` Darrick J. Wong
2016-01-03 12:07 ` [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend Christoph Hellwig
2016-01-05 1:43 ` Darrick J. Wong
2016-01-05 10:42 ` Christoph Hellwig
2016-01-07 0:32 ` Darrick J. Wong
2016-01-07 15:25 ` Christoph Hellwig
2016-01-08 10:09 ` Darrick J. Wong [this message]
2016-01-08 13:47 ` Christoph Hellwig
2016-01-09 21:17 ` Darrick J. Wong
2016-01-10 7:54 ` Christoph Hellwig
2016-01-10 22:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108100933.GN28330@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox