From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: jkosina@suse.cz, xfs@oss.sgi.com
Subject: Re: [PATCH] Revert "xfs: clear PF_NOFREEZE for xfsaild kthread"
Date: Wed, 13 Jan 2016 08:22:26 -0500 [thread overview]
Message-ID: <20160113132226.GA37138@bfoster.bfoster> (raw)
In-Reply-To: <1452661968-11482-1-git-send-email-david@fromorbit.com>
On Wed, Jan 13, 2016 at 04:12:48PM +1100, Dave Chinner wrote:
> This reverts commit 24ba16bb3d499c49974669cd8429c3e4138ab102 as it
> prevents machines from suspending. This regression occurs when the
> xfsaild is idle on entry to suspend, and so there s no activity to
> wake it from it's idle sleep and hence see that it is supposed to
> freeze. Hence the freezer times out waiting for it and suspend is
> cancelled.
>
> There is no obvious fix for this short of freezing the filesystem
> properly, so revert this change for now.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_trans_ail.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index aa67339..4f18fd9 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -497,7 +497,6 @@ xfsaild(
> long tout = 0; /* milliseconds */
>
> current->flags |= PF_MEMALLOC;
> - set_freezable();
>
> while (!kthread_should_stop()) {
> if (tout && tout <= 20)
> --
> 2.5.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-01-13 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 5:12 [PATCH] Revert "xfs: clear PF_NOFREEZE for xfsaild kthread" Dave Chinner
2016-01-13 8:37 ` Jiri Kosina
2016-01-13 13:22 ` Brian Foster [this message]
2016-01-20 8:47 ` Michal Hocko
2016-01-20 21:19 ` Dave Chinner
2016-01-21 10:21 ` Michal Hocko
2016-01-21 22:24 ` Dave Chinner
2016-01-22 9:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113132226.GA37138@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=jkosina@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox