* Suspend does not work with v4.4-rc8
@ 2016-01-04 19:26 Julian Wollrath
2016-01-04 19:40 ` Dave Chinner
0 siblings, 1 reply; 5+ messages in thread
From: Julian Wollrath @ 2016-01-04 19:26 UTC (permalink / raw)
To: xfs
Hi,
suspending (either to RAM or disk) fails with 4.4-rc8 with the
following message while v4.3.3 worked fine:
kernel: Freezing of tasks failed after 20.006 seconds (2 tasks refusing to freeze, wq_bu_busy=0):
kernel: xfsaild/dm-1 S 0000000000014100 0 283 2 0x00000000
kernel: ffff880213f53e10 ffffffff8180e4c0 ffff880213f05040 0000000000000000
kernel: 0000000000000000 ffff880213f54000 0000000000000000 0000000000000000
kernel: ffff8800ca389e40 ffff8800ca392000 ffff880213f53ed0 ffffffff814cd8ac
kernel: Call Trace:
kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
kernel: xfsaild/sda1 S 0000000000014100 0 591 2 0x00000000
kernel: ffff88021193be10 ffff8802159c4dc0 ffff880213ab9340 0000000000000000
kernel: 0000000000000000 ffff88021193c000 0000000000000000 0000000000000000
kernel: ffff8800ca2a4240 ffff880214eea000 ffff88021193bed0 ffffffff814cd8ac
kernel: Call Trace:
kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
Please tell me what more information you need to be able to fix this
issue.
With best regards,
Julian Wollrath
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Suspend does not work with v4.4-rc8
2016-01-04 19:26 Suspend does not work with v4.4-rc8 Julian Wollrath
@ 2016-01-04 19:40 ` Dave Chinner
2016-01-08 10:44 ` Jiri Kosina
2016-01-14 14:36 ` Julian Wollrath
0 siblings, 2 replies; 5+ messages in thread
From: Dave Chinner @ 2016-01-04 19:40 UTC (permalink / raw)
To: Julian Wollrath; +Cc: Jiri Kosina, xfs
On Mon, Jan 04, 2016 at 08:26:11PM +0100, Julian Wollrath wrote:
> Hi,
>
> suspending (either to RAM or disk) fails with 4.4-rc8 with the
> following message while v4.3.3 worked fine:
>
> kernel: Freezing of tasks failed after 20.006 seconds (2 tasks refusing to freeze, wq_bu_busy=0):
> kernel: xfsaild/dm-1 S 0000000000014100 0 283 2 0x00000000
> kernel: ffff880213f53e10 ffffffff8180e4c0 ffff880213f05040 0000000000000000
> kernel: 0000000000000000 ffff880213f54000 0000000000000000 0000000000000000
> kernel: ffff8800ca389e40 ffff8800ca392000 ffff880213f53ed0 ffffffff814cd8ac
> kernel: Call Trace:
> kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
> kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> kernel: xfsaild/sda1 S 0000000000014100 0 591 2 0x00000000
> kernel: ffff88021193be10 ffff8802159c4dc0 ffff880213ab9340 0000000000000000
> kernel: 0000000000000000 ffff88021193c000 0000000000000000 0000000000000000
> kernel: ffff8800ca2a4240 ffff880214eea000 ffff88021193bed0 ffffffff814cd8ac
> kernel: Call Trace:
> kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
> kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
>
> Please tell me what more information you need to be able to fix this
> issue.
The freezer detection is broken. The thread is sleeping in schedule
until a wakeup occurs some time in the future, which means it cannot
"enter then freezer" because it's not a running thread. This is a
problem introduced by commit 24ba16b ("xfs: clear PF_NOFREEZE for
xfsaild kthread").
Jiri, I'm tempted just to revert this change - if the freezer
doesn't detect processes that are not in TASK_RUNNABLE state as
frozeni or can't mark them as frozen, then this change will never
work reliably for XFS....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Suspend does not work with v4.4-rc8
2016-01-04 19:40 ` Dave Chinner
@ 2016-01-08 10:44 ` Jiri Kosina
2016-01-08 21:31 ` Dave Chinner
2016-01-14 14:36 ` Julian Wollrath
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2016-01-08 10:44 UTC (permalink / raw)
To: Dave Chinner; +Cc: Julian Wollrath, xfs
On Tue, 5 Jan 2016, Dave Chinner wrote:
> > kernel: Freezing of tasks failed after 20.006 seconds (2 tasks refusing to freeze, wq_bu_busy=0):
> > kernel: xfsaild/dm-1 S 0000000000014100 0 283 2 0x00000000
> > kernel: ffff880213f53e10 ffffffff8180e4c0 ffff880213f05040 0000000000000000
> > kernel: 0000000000000000 ffff880213f54000 0000000000000000 0000000000000000
> > kernel: ffff8800ca389e40 ffff8800ca392000 ffff880213f53ed0 ffffffff814cd8ac
> > kernel: Call Trace:
> > kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> > kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> > kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
> > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> > kernel: xfsaild/sda1 S 0000000000014100 0 591 2 0x00000000
> > kernel: ffff88021193be10 ffff8802159c4dc0 ffff880213ab9340 0000000000000000
> > kernel: 0000000000000000 ffff88021193c000 0000000000000000 0000000000000000
> > kernel: ffff8800ca2a4240 ffff880214eea000 ffff88021193bed0 ffffffff814cd8ac
> > kernel: Call Trace:
> > kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> > kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> > kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
> > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> >
> > Please tell me what more information you need to be able to fix this
> > issue.
>
> The freezer detection is broken. The thread is sleeping in schedule
> until a wakeup occurs some time in the future, which means it cannot
> "enter then freezer" because it's not a running thread. This is a
> problem introduced by commit 24ba16b ("xfs: clear PF_NOFREEZE for
> xfsaild kthread").
>
> Jiri, I'm tempted just to revert this change - if the freezer
> doesn't detect processes that are not in TASK_RUNNABLE state as
> frozeni or can't mark them as frozen, then this change will never
> work reliably for XFS....
Well, clearly the thread is sleeping in schedule() during the freezing
operation and it's supposed to be doing so; therefore it doesn't need
explicit freezing point, right?
So the proper fix would rather be something like
From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] xfs: xfsaild doesn't need to be freezable
Commit 24ba16b ("xfs: clear PF_NOFREEZE for xfsaild kthread") introduced
clearing of the PF_NOFREEZE flag for xfsaild.
It turns out though that the normal mode of operation through the system
suspend for xfsaild is to sleep in schedule(), and therefore it doesn't
need explicit freezing point (even more so that the actual freezing point
is *just* after coming out of schedule() (and only there), which doesn't
make sense by itself either).
Let's just make xfsaild explicitly non-freezable and keep it sleep in
schedule() during system suspend, as it was before 24ba16b.
Reported-by: Dave Chinner <david@fromorbit.com>
Reported-by: Julian Wollrath <jwollrath@web.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
fs/xfs/xfs_trans_ail.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index aa67339..760d303 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -497,7 +497,6 @@ xfsaild(
long tout = 0; /* milliseconds */
current->flags |= PF_MEMALLOC;
- set_freezable();
while (!kthread_should_stop()) {
if (tout && tout <= 20)
@@ -531,8 +530,6 @@ xfsaild(
__set_current_state(TASK_RUNNING);
- try_to_freeze();
-
tout = xfsaild_push(ailp);
}
--
Jiri Kosina
SUSE Labs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: Suspend does not work with v4.4-rc8
2016-01-08 10:44 ` Jiri Kosina
@ 2016-01-08 21:31 ` Dave Chinner
0 siblings, 0 replies; 5+ messages in thread
From: Dave Chinner @ 2016-01-08 21:31 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Julian Wollrath, xfs
On Fri, Jan 08, 2016 at 11:44:21AM +0100, Jiri Kosina wrote:
> On Tue, 5 Jan 2016, Dave Chinner wrote:
>
> > > kernel: Freezing of tasks failed after 20.006 seconds (2 tasks refusing to freeze, wq_bu_busy=0):
> > > kernel: xfsaild/dm-1 S 0000000000014100 0 283 2 0x00000000
> > > kernel: ffff880213f53e10 ffffffff8180e4c0 ffff880213f05040 0000000000000000
> > > kernel: 0000000000000000 ffff880213f54000 0000000000000000 0000000000000000
> > > kernel: ffff8800ca389e40 ffff8800ca392000 ffff880213f53ed0 ffffffff814cd8ac
> > > kernel: Call Trace:
> > > kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> > > kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> > > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > > kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> > > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> > > kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
> > > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> > > kernel: xfsaild/sda1 S 0000000000014100 0 591 2 0x00000000
> > > kernel: ffff88021193be10 ffff8802159c4dc0 ffff880213ab9340 0000000000000000
> > > kernel: 0000000000000000 ffff88021193c000 0000000000000000 0000000000000000
> > > kernel: ffff8800ca2a4240 ffff880214eea000 ffff88021193bed0 ffffffff814cd8ac
> > > kernel: Call Trace:
> > > kernel: [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> > > kernel: [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> > > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > > kernel: [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> > > kernel: [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> > > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> > > kernel: [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70
> > > kernel: [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> > >
> > > Please tell me what more information you need to be able to fix this
> > > issue.
> >
> > The freezer detection is broken. The thread is sleeping in schedule
> > until a wakeup occurs some time in the future, which means it cannot
> > "enter then freezer" because it's not a running thread. This is a
> > problem introduced by commit 24ba16b ("xfs: clear PF_NOFREEZE for
> > xfsaild kthread").
> >
> > Jiri, I'm tempted just to revert this change - if the freezer
> > doesn't detect processes that are not in TASK_RUNNABLE state as
> > frozeni or can't mark them as frozen, then this change will never
> > work reliably for XFS....
>
> Well, clearly the thread is sleeping in schedule() during the freezing
> operation and it's supposed to be doing so; therefore it doesn't need
> explicit freezing point, right?
No.
It's sleeping in schedule because it's got nothing more to do - it's
issued all it's IO and is idle. It is not going to run again until
filesystem modification activity is restarted.
But if the AIL still has objects in it (like it will after a sync),
then it will continue to run and issue IO until it returns to the
empty, idle state. In this active state, we need to freeze the
thread on suspend so that it doesn't keep issuing IO all through the
suspend process...
> So the proper fix would rather be something like
>
>
>
> From: Jiri Kosina <jkosina@suse.cz>
> Subject: [PATCH] xfs: xfsaild doesn't need to be freezable
No, that just means we guarantee that there will be suspend image
coherency problems when suspend is run on a busy filesystem...
This process is not going to enter a runable state, so is never
going to enter the freezer. But we can't be certain of that,
because we haven't frozen the filesystem and hence it can still be
modified and this thread could be woken and do stuff when it
shouldn't.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Suspend does not work with v4.4-rc8
2016-01-04 19:40 ` Dave Chinner
2016-01-08 10:44 ` Jiri Kosina
@ 2016-01-14 14:36 ` Julian Wollrath
1 sibling, 0 replies; 5+ messages in thread
From: Julian Wollrath @ 2016-01-14 14:36 UTC (permalink / raw)
To: Dave Chinner; +Cc: Jiri Kosina, xfs
Hi,
> The freezer detection is broken. The thread is sleeping in schedule
> until a wakeup occurs some time in the future, which means it cannot
> "enter then freezer" because it's not a running thread. This is a
> problem introduced by commit 24ba16b ("xfs: clear PF_NOFREEZE for
> xfsaild kthread").
reverting this commit gets rid of the problem and lets me suspend my
machine again.
Cheers,
Julian
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-14 14:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 19:26 Suspend does not work with v4.4-rc8 Julian Wollrath
2016-01-04 19:40 ` Dave Chinner
2016-01-08 10:44 ` Jiri Kosina
2016-01-08 21:31 ` Dave Chinner
2016-01-14 14:36 ` Julian Wollrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox