From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_db: check on-disk structure sizes
Date: Fri, 15 Jan 2016 12:56:29 -0800 [thread overview]
Message-ID: <20160115205629.GA5757@birch.djwong.org> (raw)
In-Reply-To: <20160113074640.GA21939@infradead.org>
On Tue, Jan 12, 2016 at 11:46:40PM -0800, Christoph Hellwig wrote:
> On Wed, Jan 13, 2016 at 12:02:36AM -0600, Eric Sandeen wrote:
> > > As I've pointed out previously to Darrick: xfstests:/tests/xfs/122
> > >
> > > Make that build again, update it.
> > >
> > Oh, I went looking for that and missed it somehow, thought it had been removed. Ok then!
>
> The real issue is that build environment change alignments. 32 vs 64
> bit builds are obvious, but on some architectures different ABIs have
> different alignments (we had some fun with ARM in that regard),
> nevermind the equivalents to IRIX n32 popping up everywhere these days
> that make things complicated.
>
> I'd really love to have Darrick's check in xfs_format.h as an opt-in
> if a build time assert is provided - that way every user can check it
> doesn't screw up the structures.
I've fixed xfs/122, so I suppose we no longer need this to end up in
xfsprogs. The kernel-side patch can stick around in fs/xfs/ without
touching libxfs.
(New patches out soonish.)
--D
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-01-15 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 23:46 [PATCH] xfs_db: check on-disk structure sizes Darrick J. Wong
2016-01-12 14:01 ` Brian Foster
2016-01-13 1:29 ` Darrick J. Wong
2016-01-13 3:10 ` Eric Sandeen
2016-01-13 5:47 ` Dave Chinner
2016-01-13 6:02 ` Eric Sandeen
2016-01-13 7:46 ` Christoph Hellwig
2016-01-15 20:56 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115205629.GA5757@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox