From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 8F2F57F37 for ; Tue, 19 Jan 2016 23:13:00 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 3B2E3AC003 for ; Tue, 19 Jan 2016 21:12:57 -0800 (PST) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id 2QCi9wAldW4CwsLt (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Tue, 19 Jan 2016 21:12:52 -0800 (PST) Date: Tue, 19 Jan 2016 21:12:48 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH] xfs: check sizes of XFS on-disk structures at compile time Message-ID: <20160120051248.GA5744@birch.djwong.org> References: <20160111232657.GA7831@birch.djwong.org> <20160115205801.GB5757@birch.djwong.org> <20160115225219.GP6033@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160115225219.GP6033@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Sat, Jan 16, 2016 at 09:52:19AM +1100, Dave Chinner wrote: > On Fri, Jan 15, 2016 at 12:58:01PM -0800, Darrick J. Wong wrote: > > On Mon, Jan 11, 2016 at 03:26:57PM -0800, Darrick J. Wong wrote: > > > Check the sizes of XFS on-disk structures when compiling the kernel. > > > Use this to catch inadvertent changes in structure size due to padding > > > and alignment issues, etc. > > > > > > Signed-off-by: Darrick J. Wong > .... > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_efi_log_format_64, 32); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_efd_log_format_32, 28); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_efd_log_format_64, 32); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_dq_logformat, 24); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_qoff_logformat, 20); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_icreate_log, 28); > > > +} > > > > Perhaps this huge function ought to hide away in its own file? > > Yes, I think that's a good idea, and I think it should only be built > on debug builds, too. Ok, I'll make it go away when !CONFIG_XFS_DEBUG. --D > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs