From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 0ED8D7F37 for ; Wed, 20 Jan 2016 09:40:41 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id D86608F804C for ; Wed, 20 Jan 2016 07:40:37 -0800 (PST) Received: from josefsipek.net (josefsipek.net [71.174.113.7]) by cuda.sgi.com with ESMTP id vs33or1nXAaLkNgI for ; Wed, 20 Jan 2016 07:40:34 -0800 (PST) Date: Wed, 20 Jan 2016 10:40:36 -0500 From: Josef 'Jeff' Sipek Subject: Re: [PATCH] xfs: check sizes of XFS on-disk structures at compile time Message-ID: <20160120154035.GH1366@meili.valhalla.31bits.net> References: <20160111232657.GA7831@birch.djwong.org> <20160115205801.GB5757@birch.djwong.org> <20160115225219.GP6033@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160115225219.GP6033@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com, "Darrick J. Wong" On Sat, Jan 16, 2016 at 09:52:19AM +1100, Dave Chinner wrote: > On Fri, Jan 15, 2016 at 12:58:01PM -0800, Darrick J. Wong wrote: > > On Mon, Jan 11, 2016 at 03:26:57PM -0800, Darrick J. Wong wrote: > > > Check the sizes of XFS on-disk structures when compiling the kernel. > > > Use this to catch inadvertent changes in structure size due to padding > > > and alignment issues, etc. > > > > > > Signed-off-by: Darrick J. Wong > .... > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_efi_log_format_64, 32); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_efd_log_format_32, 28); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_efd_log_format_64, 32); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_dq_logformat, 24); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_qoff_logformat, 20); > > > + XFS_CHECK_STRUCT_SIZE(struct xfs_icreate_log, 28); > > > +} > > > > Perhaps this huge function ought to hide away in its own file? > > Yes, I think that's a good idea, and I think it should only be built > on debug builds, too. Doesn't this turn into nothingness as far as the generated binary is concerned? Because if it does, I don't see a reason to keep it debug-only. Afterall, non-debug builds need to be correct and these are pretty important checks. We certainly don't want another ARM structure padding & alignment fiasco. Just my 2 cents, Jeff. -- Only two things are infinite, the universe and human stupidity, and I'm not sure about the former. - Albert Einstein _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs