From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id BEEA07F47 for ; Sat, 23 Jan 2016 00:18:23 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id A0C628F8049 for ; Fri, 22 Jan 2016 22:18:20 -0800 (PST) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id 373acw7kLON6Uzsd (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 22 Jan 2016 22:18:15 -0800 (PST) Date: Fri, 22 Jan 2016 22:18:11 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH 1/5] xfs_io: detect the '-R' option in getopt Message-ID: <20160123061811.GC5500@birch.djwong.org> References: <20160123003502.2475.99558.stgit@birch.djwong.org> <56A307D8.60202@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56A307D8.60202@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs@oss.sgi.com On Fri, Jan 22, 2016 at 10:55:52PM -0600, Eric Sandeen wrote: > On 1/22/16 6:35 PM, Darrick J. Wong wrote: > > Configure getopt to accept the -R argument to pwrite. > > Did you have anything against "F" and "B"? :) > > (They're missing too but in the case statements & help) No, but I /was/ wondering if the omission was deliberate? --D > > -Eric > > > Signed-off-by: Darrick J. Wong > > --- > > io/pwrite.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/io/pwrite.c b/io/pwrite.c > > index fd9114d..c6efee9 100644 > > --- a/io/pwrite.c > > +++ b/io/pwrite.c > > @@ -259,7 +259,7 @@ pwrite_f( > > init_cvtnum(&fsblocksize, &fssectsize); > > bsize = fsblocksize; > > > > - while ((c = getopt(argc, argv, "b:Cdf:i:qs:S:uV:wWZ:")) != EOF) { > > + while ((c = getopt(argc, argv, "b:Cdf:i:qRs:S:uV:wWZ:")) != EOF) { > > switch (c) { > > case 'b': > > tmp = cvtnum(fsblocksize, fssectsize, optarg); > > > > _______________________________________________ > > xfs mailing list > > xfs@oss.sgi.com > > http://oss.sgi.com/mailman/listinfo/xfs > > > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs