Polish translation update + localization remark for xfsprogs 4.3.0

Polish translation update + localization remark for xfsprogs 4.3.0

[Jakub Bogusz]

Hello,

I've just updated Polish translation for xfsprogs 4.3.0, it's available
at:
http://qboosh.pl/pl.po/xfsprogs-4.3.0.pl.po

I have noticed untranslatable message part in repair/versions.c:228:

_("WARNING: you have a V1 inode filesystem. It %s be converted to a\n"
  "\tversion 2 inode filesystem. If you do not want this, run an older\n"
  "\tversion of xfs_repair.\n"), no_modify ? "would" : "will");

There are untranslatable "would"/"will" strings.
This code could look for example like this:

_("WARNING: you have a V1 inode filesystem. %s to a\n"
  "\tversion 2 inode filesystem. If you do not want this, run an older\n"
  "\tversion of xfs_repair.\n"),
  no_modify ? _("It would be converted") : _("It will be converted"));

(note: using _("would") : _("will") is not enough - these words are
untranslatable to many languages without wider context)


-- 
Jakub Bogusz    http://qboosh.pl/

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH] xfs_repair: Fix untranslatable strings

[Eric Sandeen]

Don't substitute in "would" or "will" for %s here, it makes
it untranslatable.  Just spell it out twice like every other
message in the function.

Reported-by: Jakub Bogusz <qboosh@pld-linux.org>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/repair/versions.c b/repair/versions.c
index 1585385..978f48b 100644
--- a/repair/versions.c
+++ b/repair/versions.c
@@ -224,10 +224,17 @@ _("WARNING:  you have disallowed attr2 attributes but this filesystem\n"
 	}
 
 	if (!(sb->sb_versionnum & XFS_SB_VERSION_NLINKBIT)) {
-		do_warn(
-_("WARNING: you have a V1 inode filesystem. It %s be converted to a\n"
+		if (!no_modify) {
+			do_warn(
+_("WARNING: you have a V1 inode filesystem. It will be converted to a\n"
   "\tversion 2 inode filesystem. If you do not want this, run an older\n"
-  "\tversion of xfs_repair.\n"), no_modify ? "would" : "will");
+  "\tversion of xfs_repair.\n"));
+		} else  {
+			do_warn(
+_("WARNING: you have a V1 inode filesystem. It would be converted to a\n"
+  "\tversion 2 inode filesystem. If you do not want this, run an older\n"
+  "\tversion of xfs_repair.\n"));
+		}
 	}
 
 	if (xfs_sb_version_hasquota(sb))  {

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_repair: Fix untranslatable strings

[Christoph Hellwig]

On Sun, Jan 24, 2016 at 11:08:24AM -0600, Eric Sandeen wrote:
> Don't substitute in "would" or "will" for %s here, it makes
> it untranslatable.  Just spell it out twice like every other
> message in the function.
> 
> Reported-by: Jakub Bogusz <qboosh@pld-linux.org>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Polish translation update + localization remark for xfsprogs 4.3.0

[Christoph Hellwig]

On Sun, Jan 24, 2016 at 04:58:53PM +0100, Jakub Bogusz wrote:
> Hello,
> 
> I've just updated Polish translation for xfsprogs 4.3.0, it's available
> at:
> http://qboosh.pl/pl.po/xfsprogs-4.3.0.pl.po

Looks fine to me:

Acked-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs