From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs <xfs@oss.sgi.com>
Subject: Re: [PATCH v2] xfs: fix endianness error when checking log block crc on big endian platforms
Date: Tue, 26 Jan 2016 14:49:26 -0500 [thread overview]
Message-ID: <20160126194925.GB54800@bfoster.bfoster> (raw)
In-Reply-To: <20160126192105.GB6757@birch.djwong.org>
On Tue, Jan 26, 2016 at 11:21:05AM -0800, Darrick J. Wong wrote:
> Since the checksum function and the field are both __le32, don't
> perform endian conversion when comparing the two. This fixes mount
> failures on ppc64.
>
> v2: fix the other crc comparison
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Thanks!
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_log_recover.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index da37beb..594f7e6 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -4491,7 +4491,7 @@ xlog_recover_process(
> * know precisely what failed.
> */
> if (pass == XLOG_RECOVER_CRCPASS) {
> - if (rhead->h_crc && crc != le32_to_cpu(rhead->h_crc))
> + if (rhead->h_crc && crc != rhead->h_crc)
> return -EFSBADCRC;
> return 0;
> }
> @@ -4502,7 +4502,7 @@ xlog_recover_process(
> * zero CRC check prevents warnings from being emitted when upgrading
> * the kernel from one that does not add CRCs by default.
> */
> - if (crc != le32_to_cpu(rhead->h_crc)) {
> + if (crc != rhead->h_crc) {
> if (rhead->h_crc || xfs_sb_version_hascrc(&log->l_mp->m_sb)) {
> xfs_alert(log->l_mp,
> "log record CRC mismatch: found 0x%x, expected 0x%x.",
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-01-26 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 19:21 [PATCH v2] xfs: fix endianness error when checking log block crc on big endian platforms Darrick J. Wong
2016-01-26 19:49 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126194925.GB54800@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox